Changeset 206211 in webkit

Timestamp:

Sep 21, 2016 9:25:14 AM (8 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
​https://bugs.webkit.org/show_bug.cgi?id=162307

Reviewed by Eric Carlson.

The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::detachFromElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasource/MediaSource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-21  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
+        https://bugs.webkit.org/show_bug.cgi?id=162307
+
+        Reviewed by Eric Carlson.
+
+        The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
+        it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().
+
+        * Modules/mediasource/MediaSource.cpp:
+        (WebCore::MediaSource::detachFromElement):
+
 2016-09-19  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/Modules/mediasource/MediaSource.cpp

@@ -892 +892 @@
 {
     ASSERT_UNUSED(element, m_mediaElement == &element);
-    ASSERT(!isClosed());
 
     // 2.4.2 Detaching from a media element