Changeset 206234 in webkit

Timestamp:

Sep 21, 2016 1:53:49 PM (8 years ago)

Author:

pvollan@apple.com

Message:

[Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
​https://bugs.webkit.org/show_bug.cgi?id=162266
<rdar://problem/28345073>

Reviewed by Brent Fulgham.

Add null pointer check.

• platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/ca/win/CACFLayerTreeHost.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-21  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
+        https://bugs.webkit.org/show_bug.cgi?id=162266
+        <rdar://problem/28345073>
+
+        Reviewed by Brent Fulgham.
+
+        Add null pointer check.
+
+        * platform/graphics/ca/win/CACFLayerTreeHost.cpp:
+        (WebCore::CACFLayerTreeHost::create):
+
 2016-09-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp

@@ -32 +32 @@
 #include "FrameView.h"
 #include "LayerChangesFlusher.h"
+#include "Logging.h"
 #include "MainFrame.h"
 #include "PlatformCALayerWin.h"
@@ -118 +119 @@
         return nullptr;
     RefPtr<CACFLayerTreeHost> host = WKCACFViewLayerTreeHost::create();
+    if (!host) {
+        LOG_ERROR("Failed to create layer tree host for accelerated compositing.");
+        return nullptr;
+    }
     host->initialize();
     return host.release();