Changeset 206236 in webkit


Ignore:
Timestamp:
Sep 21, 2016 2:22:00 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r206222 and r206227.
​https://bugs.webkit.org/show_bug.cgi?id=162361

"broke the windows build" (Requested by keith_mi_ on #webkit).

Reverted changesets:

"Fix build for future versions of Clang."
​https://bugs.webkit.org/show_bug.cgi?id=162346
​http://trac.webkit.org/changeset/206222

"Attempt to fix windows build after r206222."
​http://trac.webkit.org/changeset/206227

Location:
trunk
Files:
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r206226 r206236  
     12016-09-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r206222 and r206227.
     4        https://bugs.webkit.org/show_bug.cgi?id=162361
     5
     6        "broke the windows build" (Requested by keith_mi_ on #webkit).
     7
     8        Reverted changesets:
     9
     10        "Fix build for future versions of Clang."
     11        https://bugs.webkit.org/show_bug.cgi?id=162346
     12        http://trac.webkit.org/changeset/206222
     13
     14        "Attempt to fix windows build after r206222."
     15        http://trac.webkit.org/changeset/206227
     16
    1172016-09-21  Filip Pizlo  <fpizlo@apple.com>
    218

  • trunk/Source/JavaScriptCore/runtime/VM.h

    r206222 r206236  
    617617    JS_EXPORT_PRIVATE void queueMicrotask(JSGlobalObject*, PassRefPtr<Microtask>);
    618618    JS_EXPORT_PRIVATE void drainMicrotasks();
    619     void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
     619    JS_EXPORT_PRIVATE void setGlobalConstRedeclarationShouldThrow(bool globalConstRedeclarationThrow) { m_globalConstRedeclarationShouldThrow = globalConstRedeclarationThrow; }
    620620    ALWAYS_INLINE bool globalConstRedeclarationShouldThrow() const { return m_globalConstRedeclarationShouldThrow; }
    621621

  • trunk/Source/WTF/ChangeLog

    r206222 r206236  
     12016-09-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r206222 and r206227.
     4        https://bugs.webkit.org/show_bug.cgi?id=162361
     5
     6        "broke the windows build" (Requested by keith_mi_ on #webkit).
     7
     8        Reverted changesets:
     9
     10        "Fix build for future versions of Clang."
     11        https://bugs.webkit.org/show_bug.cgi?id=162346
     12        http://trac.webkit.org/changeset/206222
     13
     14        "Attempt to fix windows build after r206222."
     15        http://trac.webkit.org/changeset/206227
     16
    1172016-09-21  Keith Miller  <keith_miller@apple.com>
    218

  • trunk/Source/WTF/wtf/text/StringImpl.h

    r206222 r206236  
    949949bool equalIgnoringASCIICase(const StringImpl&, const StringImpl&);
    950950WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const StringImpl*);
    951 bool equalIgnoringASCIICase(const StringImpl&, const char*);
    952 bool equalIgnoringASCIICase(const StringImpl*, const char*);
     951WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl&, const char*);
     952WTF_EXPORT_STRING_API bool equalIgnoringASCIICase(const StringImpl*, const char*);
    953953
    954954WTF_EXPORT_STRING_API bool equalIgnoringASCIICaseNonNull(const StringImpl*, const StringImpl*);

  • trunk/Source/WebCore/ChangeLog

    r206235 r206236  
     12016-09-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r206222 and r206227.
     4        https://bugs.webkit.org/show_bug.cgi?id=162361
     5
     6        "broke the windows build" (Requested by keith_mi_ on #webkit).
     7
     8        Reverted changesets:
     9
     10        "Fix build for future versions of Clang."
     11        https://bugs.webkit.org/show_bug.cgi?id=162346
     12        http://trac.webkit.org/changeset/206222
     13
     14        "Attempt to fix windows build after r206222."
     15        http://trac.webkit.org/changeset/206227
     16
    1172016-09-21  Alex Christensen  <achristensen@webkit.org>
    218

  • trunk/Source/WebCore/Configurations/WebCore.unexp

    r206222 r206236  
    4848_DDDFAScannerFirstResultInUnicharArray
    4949# Source/WebCore/page/mac/ServicesOverlayController.mm
    50 _DDHighlightGetLayerWithContext
    51 _DDHighlightGetBoundingRect
    5250_DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection
    5351_DDHighlightPointIsOnHighlight
    54 
    5552
    5653# Subclasses of an exported C++ class in JavaScriptCore.

  • trunk/Source/WebCore/dom/Exception.h

    r206222 r206236  
    3535    explicit Exception(ExceptionCode);
    3636
    37     ExceptionCode code() const;
     37    WEBCORE_EXPORT ExceptionCode code() const;
    3838
    3939private:

  • trunk/Source/WebCore/page/Frame.h

    r206222 r206236  
    136136
    137137        MainFrame& mainFrame() const;
    138         bool isMainFrame() const;
     138        WEBCORE_EXPORT bool isMainFrame() const;
    139139
    140140        Page* page() const;

  • trunk/Source/WebCore/page/MainFrame.h

    r206227 r206236  
    9090};
    9191
    92 ALWAYS_INLINE bool Frame::isMainFrame() const
     92inline bool Frame::isMainFrame() const
    9393{
    9494    return this == &m_mainFrame;

  • trunk/Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h

    r206222 r206236  
    4949    WEBCORE_EXPORT virtual ~WebPlaybackSessionModelMediaElement();
    5050    WEBCORE_EXPORT void setMediaElement(HTMLMediaElement*);
    51     HTMLMediaElement* mediaElement() const { return m_mediaElement.get(); }
     51    WEBCORE_EXPORT HTMLMediaElement* mediaElement() const { return m_mediaElement.get(); }
    5252
    5353    WEBCORE_EXPORT void handleEvent(WebCore::ScriptExecutionContext*, WebCore::Event*) final;

  • trunk/Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h

    r206222 r206236  
    5555    WEBCORE_EXPORT virtual ~WebVideoFullscreenModelVideoElement();
    5656    WEBCORE_EXPORT void setVideoElement(HTMLVideoElement*);
    57     HTMLVideoElement* videoElement() const { return m_videoElement.get(); }
     57    WEBCORE_EXPORT HTMLVideoElement* videoElement() const { return m_videoElement.get(); }
    5858    WEBCORE_EXPORT void setVideoFullscreenLayer(PlatformLayer*, std::function<void()> completionHandler = [] { });
    5959    WEBCORE_EXPORT void waitForPreparedForInlineThen(std::function<void()> completionHandler = [] { });

  • trunk/Source/WebCore/platform/graphics/Color.h

    r206222 r206236  
    6767
    6868WEBCORE_EXPORT RGBA32 colorWithOverrideAlpha(RGBA32 color, float overrideAlpha);
    69 RGBA32 colorWithOverrideAlpha(RGBA32 color, Optional<float> overrideAlpha);
     69WEBCORE_EXPORT RGBA32 colorWithOverrideAlpha(RGBA32 color, Optional<float> overrideAlpha);
    7070
    7171WEBCORE_EXPORT RGBA32 makeRGBA32FromFloats(float r, float g, float b, float a);

  • trunk/Source/WebCore/platform/graphics/transforms/TransformationMatrix.h

    r206222 r206236  
    232232
    233233    // Angle is in degrees.
    234     TransformationMatrix& rotate(double d) { return rotate3d(0, 0, d); }
     234    WEBCORE_EXPORT TransformationMatrix& rotate(double d) { return rotate3d(0, 0, d); }
    235235    TransformationMatrix& rotateFromVector(double x, double y);
    236236    WEBCORE_EXPORT TransformationMatrix& rotate3d(double rx, double ry, double rz);

  • trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h

    r206222 r206236  
    7979    WEBCORE_EXPORT void cleanupFullscreen();
    8080    WEBCORE_EXPORT void invalidate();
    81     void requestHideAndExitFullscreen() { }
     81    WEBCORE_EXPORT void requestHideAndExitFullscreen() { }
    8282    WEBCORE_EXPORT void preparedToReturnToInline(bool visible, const IntRect& inlineRect, NSWindow *parentWindow);
    8383    WEBCORE_EXPORT void ensureControlsManager();
    … …  
    9191    bool isPlayingVideoInEnhancedFullscreen() const;
    9292
    93     bool mayAutomaticallyShowVideoPictureInPicture() const { return false; }
     93    WEBCORE_EXPORT bool mayAutomaticallyShowVideoPictureInPicture() const { return false; }
    9494    void applicationDidBecomeActive() { }
    9595

  • trunk/Source/WebCore/platform/network/ParsedContentRange.h

    r206222 r206236  
    3434public:
    3535    WEBCORE_EXPORT explicit ParsedContentRange(const String&);
    36     ParsedContentRange() { }
     36    WEBCORE_EXPORT ParsedContentRange() { }
    3737    WEBCORE_EXPORT ParsedContentRange(int64_t firstBytePosition, int64_t lastBytePosition, int64_t instanceLength);
    3838
    39     bool isValid() const { return m_isValid; }
     39    WEBCORE_EXPORT bool isValid() const { return m_isValid; }
    4040    int64_t firstBytePosition() const { return m_firstBytePosition; }
    4141    int64_t lastBytePosition() const { return m_lastBytePosition; }

  • trunk/Source/WebCore/platform/network/ResourceResponseBase.h

    r206222 r206236  
    116116
    117117    WEBCORE_EXPORT void includeCertificateInfo() const;
    118     const Optional<CertificateInfo>& certificateInfo() const { return m_certificateInfo; };
     118    WEBCORE_EXPORT const Optional<CertificateInfo>& certificateInfo() const { return m_certificateInfo; };
    119119   
    120120    // These functions return parsed values of the corresponding response headers.

  • trunk/Source/WebCore/platform/text/TextStream.h

    r206222 r206236  
    7878    WEBCORE_EXPORT void nextLine(); // Output newline and indent.
    7979
    80     void increaseIndent() { ++m_indent; }
    81     void decreaseIndent() { --m_indent; ASSERT(m_indent >= 0); }
     80    WEBCORE_EXPORT void increaseIndent() { ++m_indent; }
     81    WEBCORE_EXPORT void decreaseIndent() { --m_indent; ASSERT(m_indent >= 0); }
    8282
    8383    WEBCORE_EXPORT void writeIndent();

  • trunk/Tools/ChangeLog

    r206235 r206236  
     12016-09-21  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, rolling out r206222 and r206227.
     4        https://bugs.webkit.org/show_bug.cgi?id=162361
     5
     6        "broke the windows build" (Requested by keith_mi_ on #webkit).
     7
     8        Reverted changesets:
     9
     10        "Fix build for future versions of Clang."
     11        https://bugs.webkit.org/show_bug.cgi?id=162346
     12        http://trac.webkit.org/changeset/206222
     13
     14        "Attempt to fix windows build after r206222."
     15        http://trac.webkit.org/changeset/206227
     16
    1172016-09-21  Alex Christensen  <achristensen@webkit.org>
    218

  • trunk/Tools/TestWebKitAPI/Counters.cpp

    r206222 r206236  
    3434unsigned ConstructorDestructorCounter::destructionCount = 0;
    3535
    36 template<> unsigned DeleterCounter<ConstructorDestructorCounter>::m_deleterCount = 0;
     36template<> unsigned DeleterCounter<ConstructorDestructorCounter>::deleterCount = 0;

  • trunk/Tools/TestWebKitAPI/Counters.h

    r206222 r206236  
    6666};
    6767
    68 #if COMPILER(CLANG)
    69 #if __has_warning("-Wundefined-var-template")
    70 #pragma clang diagnostic push
    71 #pragma clang diagnostic ignored "-Wundefined-var-template"
    72 #endif
    73 #endif
    7468template<typename T>
    7569struct DeleterCounter {
    76     static unsigned m_deleterCount;
    77 
    78     static unsigned deleterCount() { return m_deleterCount; }
     70    static unsigned deleterCount;
    7971
    8072    struct TestingScope {
    8173        TestingScope()
    8274        {
    83             m_deleterCount = 0;
     75            deleterCount = 0;
    8476        }
    8577    };
    … …  
    8779    void operator()(T* p) const
    8880    {
    89         m_deleterCount++;
     81        deleterCount++;
    9082        delete p;
    9183    }
    9284};
    93 #if COMPILER(CLANG)
    94 #if __has_warning("-Wundefined-var-template")
    95 #pragma clang diagnostic pop
    96 #endif
    97 #endif
    9885
    9986#endif // Counters_h

  • trunk/Tools/TestWebKitAPI/Tests/WTF/HashCountedSet.cpp

    r206222 r206236  
    285285    EXPECT_EQ(0u, ConstructorDestructorCounter::destructionCount);
    286286   
    287     EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
     287    EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
    288288   
    289289    hashCountedSet.clear();
    … …  
    292292    EXPECT_EQ(1u, ConstructorDestructorCounter::destructionCount);
    293293   
    294     EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
     294    EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
    295295}
    296296

  • trunk/Tools/TestWebKitAPI/Tests/WTF/HashMap.cpp

    r206222 r206236  
    207207    EXPECT_EQ(0u, ConstructorDestructorCounter::destructionCount);
    208208
    209     EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
     209    EXPECT_EQ(0u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
    210210
    211211    map.clear();
    … …  
    214214    EXPECT_EQ(1u, ConstructorDestructorCounter::destructionCount);
    215215
    216     EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount());
     216    EXPECT_EQ(1u, DeleterCounter<ConstructorDestructorCounter>::deleterCount);
    217217}
    218218
Note: See TracChangeset for help on using the changeset viewer.