Changeset 206272 in webkit

Timestamp:

Sep 22, 2016 1:54:56 PM (8 years ago)

Author:

jer.noble@apple.com

Message:

Fullscreen controls inoperative in WebKitLegacy web views
​https://bugs.webkit.org/show_bug.cgi?id=162374

Reviewed by Eric Carlson.

After r205365, the WebPlaybackSessionInterfaceAVKit was now created after the
WebPlaybackSessionModel which fed it data, so it no longer received the burst of data upon
creation. Instead, it should have always asked the model for its cached data as soon as it
was connected to set up its inital state.

• platform/ios/WebPlaybackSessionInterfaceAVKit.mm:

(WebCore::WebPlaybackSessionInterfaceAVKit::WebPlaybackSessionInterfaceAVKit):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebPlaybackSessionInterfaceAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-22  Jer Noble  <jer.noble@apple.com>
+
+        Fullscreen controls inoperative in WebKitLegacy web views
+        https://bugs.webkit.org/show_bug.cgi?id=162374
+
+        Reviewed by Eric Carlson.
+
+        After r205365, the WebPlaybackSessionInterfaceAVKit was now created after the
+        WebPlaybackSessionModel which fed it data, so it no longer received the burst of data upon
+        creation. Instead, it should have always asked the model for its cached data as soon as it
+        was connected to set up its inital state.
+
+        * platform/ios/WebPlaybackSessionInterfaceAVKit.mm:
+        (WebCore::WebPlaybackSessionInterfaceAVKit::WebPlaybackSessionInterfaceAVKit):
+
 2016-09-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm

@@ -55 +55 @@
     [m_playerController setPlaybackSessionInterface:this];
     [m_playerController setDelegate:&model];
+
+    durationChanged(model.duration());
+    currentTimeChanged(model.currentTime(), [[NSProcessInfo processInfo] systemUptime]);
+    bufferedTimeChanged(model.bufferedTime());
+    rateChanged(model.isPlaying(), model.playbackRate());
+    seekableRangesChanged(model.seekableRanges());
+    canPlayFastReverseChanged(model.canPlayFastReverse());
+    audioMediaSelectionOptionsChanged(model.audioMediaSelectionOptions(), model.audioMediaSelectedIndex());
+    legibleMediaSelectionOptionsChanged(model.legibleMediaSelectionOptions(), model.legibleMediaSelectedIndex());
+    externalPlaybackChanged(model.externalPlaybackEnabled(), model.externalPlaybackTargetType(), model.externalPlaybackLocalizedDeviceName());
+    wirelessVideoPlaybackDisabledChanged(model.wirelessVideoPlaybackDisabled());
 }