Changeset 207082 in webkit
- Timestamp:
- Oct 11, 2016 3:42:59 AM (7 years ago)
- Location:
- releases/WebKitGTK/webkit-2.14
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
releases/WebKitGTK/webkit-2.14/LayoutTests/ChangeLog
r207080 r207082 1 2016-09-19 Zalan Bujtas <zalan@apple.com> 2 3 ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType] while loading guardian.co.uk 4 https://bugs.webkit.org/show_bug.cgi?id=162129 5 <rdar://problem/28353350> 6 7 Reviewed by Antti Koivisto. 8 9 * fast/multicol/assert-on-cliprect-caching-when-paginated-expected.txt: Added. 10 * fast/multicol/assert-on-cliprect-caching-when-paginated.html: Added. 11 1 12 2016-09-16 Chris Dumez <cdumez@apple.com> 2 13 -
releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog
r207081 r207082 1 2016-09-19 Zalan Bujtas <zalan@apple.com> 2 3 ASSERTION FAILED: clipRectsContext.rootLayer == m_clipRectsCache->m_clipRectsRoot[clipRectsType] while loading guardian.co.uk 4 https://bugs.webkit.org/show_bug.cgi?id=162129 5 <rdar://problem/28353350> 6 7 Reviewed by Antti Koivisto. 8 9 Neither ::localClipRect() nor ::selfClipRect() accounts for paginated context while computing the cliprects (See FIXMEs). 10 This patch ensures that we don't end up caching these invalid cliprects. 11 12 Test: fast/multicol/assert-on-cliprect-caching-when-paginated.html 13 14 * rendering/RenderLayer.cpp: 15 (WebCore::RenderLayer::calculateClipRects): 16 1 17 2016-09-17 David Kilzer <ddkilzer@apple.com> 2 18 -
releases/WebKitGTK/webkit-2.14/Source/WebCore/rendering/RenderLayer.cpp
r207078 r207082 5727 5727 ClipRect backgroundRect; 5728 5728 ClipRect foregroundRect; 5729 ClipRectsContext clipRectsContext(clippingRootLayer, PaintingClipRects); 5729 auto clipRectType = !m_enclosingPaginationLayer || m_enclosingPaginationLayer == clippingRootLayer ? PaintingClipRects : TemporaryClipRects; 5730 ClipRectsContext clipRectsContext(clippingRootLayer, clipRectType); 5730 5731 calculateRects(clipRectsContext, renderer().view().documentRect(), layerBounds, backgroundRect, foregroundRect, offsetFromAncestor(clippingRootLayer)); 5731 5732 return clippingRootLayer->renderer().localToAbsoluteQuad(FloatQuad(backgroundRect.rect())).enclosingBoundingBox(); … … 5743 5744 ClipRect backgroundRect; 5744 5745 ClipRect foregroundRect; 5745 ClipRectsContext clipRectsContext(clippingRootLayer, PaintingClipRects); 5746 auto clipRectType = !m_enclosingPaginationLayer || m_enclosingPaginationLayer == clippingRootLayer ? PaintingClipRects : TemporaryClipRects; 5747 ClipRectsContext clipRectsContext(clippingRootLayer, clipRectType); 5746 5748 calculateRects(clipRectsContext, LayoutRect::infiniteRect(), layerBounds, backgroundRect, foregroundRect, offsetFromRoot); 5747 5749
Note: See TracChangeset
for help on using the changeset viewer.