Changeset 207325 in webkit
- Timestamp:
- Oct 13, 2016 11:29:36 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r207324 r207325 1 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame 4 https://bugs.webkit.org/show_bug.cgi?id=146306 5 6 Reviewed by Darin Adler. 7 8 Notify about the provisional URL change when new request set for main resource load in DocumentLoader has a 9 different URL than the previous one. 10 11 * loader/DocumentLoader.cpp: 12 (WebCore::DocumentLoader::setRequest): 13 1 14 2016-10-13 Youenn Fablet <youenn@apple.com> 2 15 -
trunk/Source/WebCore/loader/DocumentLoader.cpp
r207323 r207325 235 235 handlingUnreachableURL = m_substituteData.isValid() && !m_substituteData.failingURL().isEmpty(); 236 236 237 bool shouldNotifyAboutProvisionalURLChange = false; 237 238 if (handlingUnreachableURL) 238 239 m_committed = false; 240 else if (isLoadingMainResource() && req.url() != m_request.url()) 241 shouldNotifyAboutProvisionalURLChange = true; 239 242 240 243 // We should never be getting a redirect callback after the data … … 244 247 245 248 m_request = req; 249 if (shouldNotifyAboutProvisionalURLChange) 250 frameLoader()->client().dispatchDidChangeProvisionalURL(); 246 251 } 247 252 -
trunk/Tools/ChangeLog
r207321 r207325 1 2016-10-13 Carlos Garcia Campos <cgarcia@igalia.com> 2 3 WebView and WebPage URLs not updated after URL is modified by InjectedBundlePageResourceLoadClient::willSendRequestForFrame 4 https://bugs.webkit.org/show_bug.cgi?id=146306 5 6 Reviewed by Darin Adler. 7 8 Add unit test to check that the committed URL is updated when changed in willSendRequest callback. 9 10 * TestWebKitAPI/CMakeLists.txt: 11 * TestWebKitAPI/PlatformEfl.cmake: 12 * TestWebKitAPI/PlatformGTK.cmake: 13 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp: Added. 14 (TestWebKitAPI::didCommitLoadForFrame): 15 (TestWebKitAPI::TEST): 16 * TestWebKitAPI/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp: Added. 17 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::ProvisionalURLAfterWillSendRequestCallbackTest): 18 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::willSendRequestForFrame): 19 (TestWebKitAPI::ProvisionalURLAfterWillSendRequestCallbackTest::didCommitLoadForFrame): 20 1 21 2016-10-13 Alex Christensen <achristensen@webkit.org> 2 22 -
trunk/Tools/TestWebKitAPI/CMakeLists.txt
r206470 r207325 150 150 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp 151 151 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ParentFrame_Bundle.cpp 152 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp 152 153 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp 153 154 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp -
trunk/Tools/TestWebKitAPI/PlatformEfl.cmake
r200621 r207325 98 98 PreventEmptyUserAgent 99 99 PrivateBrowsingPushStateNoHistoryCallback 100 ProvisionalURLAfterWillSendRequestCallback 100 101 ResponsivenessTimerDoesntFireEarly 101 102 ShouldGoToBackForwardListItem -
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
r204380 r207325 102 102 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/PreventEmptyUserAgent.cpp 103 103 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp 104 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ProvisionalURLAfterWillSendRequestCallback.cpp 104 105 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ReloadPageAfterCrash.cpp 105 106 ${TESTWEBKITAPI_DIR}/Tests/WebKit2/ResizeWindowAfterCrash.cpp
Note: See TracChangeset
for help on using the changeset viewer.