Changeset 207329 in webkit

Timestamp:

Oct 14, 2016 12:10:00 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
​https://bugs.webkit.org/show_bug.cgi?id=163405
<rdar://problem/28763953>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-14
Reviewed by Matt Baker.

• UserInterface/Views/SourceCodeTextEditor.js:

Use correct method name, the old one must have gone away.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SourceCodeTextEditor.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Uncaught Exception: TypeError: this.positionToOffset is not a function - seen hovering expressions with Type Profiler enabled
+        https://bugs.webkit.org/show_bug.cgi?id=163405
+        <rdar://problem/28763953>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Views/SourceCodeTextEditor.js:
+        Use correct method name, the old one must have gone away.
+
 2016-10-12  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js

@@ -1517 +1517 @@
         var sourceID = sourceCode instanceof WebInspector.Script ? sourceCode.id : sourceCode.scripts[0].id;
         var range = candidate.hoveredTokenRange;
-        var offset = this.positionToOffset({line: range.start.line, ch: range.start.ch});
+        var offset = this.currentPositionToOriginalOffset(range.start);
 
         var allRequests = [{