Changeset 207350 in webkit


Ignore:
Timestamp:
Oct 14, 2016 11:26:44 AM (7 years ago)
Author:
Simon Fraser
Message:

Annotate bots in contributors.json and don't show them on webkit.org/team
https://bugs.webkit.org/show_bug.cgi?id=163317

Reviewed by Daniel Bates.

Tools:

Add "class" : "bot" for non-humans in contributors.json and round-trip it.

  • Scripts/webkitpy/common/config/committers.py:

(Contributor.init):
(Contributor.as_dict):
(Bot):
(Bot.init):
(CommitterList.load_json):

  • Scripts/webkitpy/common/config/contributors.json:

Websites/webkit.org:

Don't show bots.

  • wp-content/themes/webkit/team.php:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r207349 r207350  
     12016-10-14  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Annotate bots in contributors.json and don't show them on webkit.org/team
     4        https://bugs.webkit.org/show_bug.cgi?id=163317
     5
     6        Reviewed by Daniel Bates.
     7       
     8        Add "class" : "bot" for non-humans in contributors.json and round-trip it.
     9
     10        * Scripts/webkitpy/common/config/committers.py:
     11        (Contributor.__init__):
     12        (Contributor.as_dict):
     13        (Bot):
     14        (Bot.__init__):
     15        (CommitterList.load_json):
     16        * Scripts/webkitpy/common/config/contributors.json:
     17
    1182016-10-14  Simon Fraser  <simon.fraser@apple.com>
    219
  • trunk/Tools/Scripts/webkitpy/common/config/committers.py

    r206980 r207350  
    6363        self.can_commit = False
    6464        self.can_review = False
     65        self.is_bot = False
    6566
    6667    def bugzilla_email(self):
     
    147148            info["expertise"] = self.expertise
    148149
     150        if self.is_bot:
     151            info["class"] = "bot"
     152
    149153        return info
    150154
     
    161165        self.can_review = True
    162166
     167
     168class Bot(Contributor):
     169    def __init__(self, name, email_or_emails, irc_nickname=None, alias_or_aliases=None, expertise=None):
     170        Contributor.__init__(self, name, email_or_emails, irc_nickname, alias_or_aliases, expertise)
     171        self.is_bot = True
    163172
    164173class CommitterList(object):
     
    200209                contributor = Committer(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
    201210                self._committers.append(contributor)
     211            elif data.get('class') == 'bot':
     212                contributor = Bot(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
    202213            else:
    203214                contributor = Contributor(name, data.get('emails'), data.get('nicks'), data.get('aliases'), data.get('expertise'))
  • trunk/Tools/Scripts/webkitpy/common/config/contributors.json

    r207161 r207350  
    150150   },
    151151   "Adobe Bug Tracker" : {
     152      "class" : "bot",
    152153      "emails" : [
    153154         "WebkitBugTracker@adobe.com"
     
    12591260   },
    12601261   "Commit Queue" : {
     1262      "class" : "bot",
    12611263      "emails" : [
    12621264         "commit-queue@webkit.org"
     
    45144516   },
    45154517   "Radar WebKit Bug Importer" : {
     4518      "class" : "bot",
    45164519      "emails" : [
    45174520         "webkit-bug-importer@group.apple.com"
     
    54615464   },
    54625465   "WebKit Review Bot" : {
     5466      "class" : "bot",
    54635467      "emails" : [
    54645468         "webkit.review.bot@gmail.com"
     
    54695473   },
    54705474   "WebKitGTK+ Bugs" : {
     5475      "class" : "bot",
    54715476      "emails" : [
    54725477         "bugs-noreply@webkitgtk.org"
  • trunk/Websites/webkit.org/ChangeLog

    r207266 r207350  
     12016-10-14  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Annotate bots in contributors.json and don't show them on webkit.org/team
     4        https://bugs.webkit.org/show_bug.cgi?id=163317
     5
     6        Reviewed by Daniel Bates.
     7       
     8        Don't show bots.
     9
     10        * wp-content/themes/webkit/team.php:
     11
    1122016-10-12  Keith Miller  <keith_miller@apple.com>
    213
  • trunk/Websites/webkit.org/wp-content/themes/webkit/team.php

    r206973 r207350  
    136136    for (var contributor in contributorsJSON) {
    137137        var data = contributorsJSON[contributor];
     138        if (data.class == "bot")
     139            continue;
    138140        contributors.push({
    139141            name: contributor,
Note: See TracChangeset for help on using the changeset viewer.