Changeset 207354 in webkit
- Timestamp:
- Oct 14, 2016 3:10:54 PM (7 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r207329 r207354 1 2016-10-14 Joseph Pecoraro <pecoraro@apple.com> 2 3 Web Inspector: Remove uses of delete in SourceCodeTextEditor 4 https://bugs.webkit.org/show_bug.cgi?id=163379 5 6 Reviewed by Timothy Hatcher. 7 8 Remove uses of delete and better group member variables. 9 One of the deletes was deleting an incorrect property. 10 11 * UserInterface/Views/SourceCodeTextEditor.js: 12 (WebInspector.SourceCodeTextEditor): 13 (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointAdded): 14 (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointRemoved): 15 (WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointMoved): 16 (WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedMarkedExpression): 17 (WebInspector.SourceCodeTextEditor.prototype._dismissEditingController): 18 (WebInspector.SourceCodeTextEditor.prototype.editingControllerDidFinishEditing): 19 1 20 2016-10-14 Joseph Pecoraro <pecoraro@apple.com> 2 21 -
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js
r207329 r207354 40 40 this._contentPopulated = false; 41 41 this._invalidLineNumbers = {0: true}; 42 this._ignoreContentDidChange = 0;43 42 this._requestingScriptContent = false; 44 43 this._activeCallFrameSourceCodeLocation = null; … … 47 46 this._typeTokenAnnotator = null; 48 47 this._basicBlockAnnotator = null; 48 this._editingController = null; 49 49 50 50 this._autoFormat = false; 51 51 this._isProbablyMinified = false; 52 53 this._ignoreContentDidChange = 0; 54 this._ignoreLocationUpdateBreakpoint = null; 55 this._ignoreBreakpointAddedBreakpoint = null; 56 this._ignoreBreakpointRemovedBreakpoint = null; 57 this._ignoreAllBreakpointLocationUpdates = false; 52 58 53 59 // FIXME: Currently this just jumps between resources and related source map resources. It doesn't "jump to symbol" yet. … … 1099 1105 1100 1106 this._ignoreBreakpointAddedBreakpoint = breakpoint; 1101 1102 1107 var shouldSkipEventDispatch = false; 1103 1108 var shouldSpeculativelyResolveBreakpoint = true; 1104 1109 WebInspector.debuggerManager.addBreakpoint(breakpoint, shouldSkipEventDispatch, shouldSpeculativelyResolveBreakpoint); 1105 delete this._ignoreBreakpointAddedBreakpoint;1110 this._ignoreBreakpointAddedBreakpoint = null; 1106 1111 1107 1112 // Return the more accurate location and breakpoint info. … … 1129 1134 this._ignoreBreakpointRemovedBreakpoint = breakpoint; 1130 1135 WebInspector.debuggerManager.removeBreakpoint(breakpoint); 1131 delete this._ignoreBreakpointAddedBreakpoint;1136 this._ignoreBreakpointRemovedBreakpoint = null; 1132 1137 } 1133 1138 … … 1150 1155 this._ignoreLocationUpdateBreakpoint = breakpoint; 1151 1156 breakpoint.sourceCodeLocation.update(this._sourceCode, unformattedNewLineInfo.lineNumber, unformattedNewLineInfo.columnNumber); 1152 delete this._ignoreLocationUpdateBreakpoint;1157 this._ignoreLocationUpdateBreakpoint = null; 1153 1158 1154 1159 var accurateNewLineInfo = this._editorLineInfoForSourceCodeLocation(breakpoint.sourceCodeLocation); … … 1772 1777 if (!color || !color.valid) { 1773 1778 editableMarker.clear(); 1774 delete this._editingController;1779 this._editingController = null; 1775 1780 return; 1776 1781 } … … 1787 1792 1788 1793 this.tokenTrackingController.hoveredMarker = null; 1789 delete this._editingController;1794 this._editingController = null; 1790 1795 } 1791 1796 … … 1812 1817 this._ignoreContentDidChange--; 1813 1818 1814 delete this._editingController;1819 this._editingController = null; 1815 1820 } 1816 1821
Note: See TracChangeset
for help on using the changeset viewer.