Changeset 207356 in webkit

Timestamp:

Oct 14, 2016 3:25:09 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
​https://bugs.webkit.org/show_bug.cgi?id=163395

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-14
Reviewed by Timothy Hatcher.

• UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype.get identifier): Renamed.
(WebInspector.Breakpoint.prototype.set identifier): Renamed.
The only user is DebuggerManager which sets and gets. Previously
it was unexpectedly setting a direct property on the Breakpoint
instead of using these methods to set the member variable.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Breakpoint.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Unused Breakpoint getter/setter for "id" - should be "identifier"
+        https://bugs.webkit.org/show_bug.cgi?id=163395
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Models/Breakpoint.js:
+        (WebInspector.Breakpoint.prototype.get identifier): Renamed.
+        (WebInspector.Breakpoint.prototype.set identifier): Renamed.
+        The only user is DebuggerManager which sets and gets. Previously
+        it was unexpectedly setting a direct property on the Breakpoint
+        instead of using these methods to set the member variable.
+
 2016-10-14  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Breakpoint.js

@@ -68 +68 @@
     // Public
 
-    get id()
+    get identifier()
     {
         return this._id;
     }
 
-    set id(id)
+    set identifier(id)
     {
         this._id = id || null;