Changeset 207385 in webkit


Ignore:
Timestamp:
Oct 15, 2016 4:53:20 PM (7 years ago)
Author:
mitz@apple.com
Message:

REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
https://bugs.webkit.org/show_bug.cgi?id=163492
<rdar://problem/28654799>

Reviewed by Darin Adler.

Source/WebKit/mac:

Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm

  • WebView/WebHTMLView.mm:

(createMenuItem): Set the tag for items that have submenus as well.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.

(-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):

Location:
trunk
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/mac/ChangeLog

    r207352 r207385  
     12016-10-15  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
     4        https://bugs.webkit.org/show_bug.cgi?id=163492
     5        <rdar://problem/28654799>
     6
     7        Reviewed by Darin Adler.
     8
     9        Test: TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm
     10
     11        * WebView/WebHTMLView.mm:
     12        (createMenuItem): Set the tag for items that have submenus as well.
     13
    1142016-10-14  Anders Carlsson  <andersca@apple.com>
    215
  • trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

    r206945 r207385  
    39573957
    39583958        auto menuItem = adoptNS([[NSMenuItem alloc] initWithTitle:item.title() action:nullptr keyEquivalent:@""]);
     3959
     3960        if (auto tag = toTag(item.action()))
     3961            [menuItem setTag:*tag];
    39593962        [menuItem setEnabled:item.enabled()];
    39603963        [menuItem setSubmenu:menu.get()];
  • trunk/Tools/ChangeLog

    r207382 r207385  
     12016-10-15  Dan Bernstein  <mitz@apple.com>
     2
     3        REGRESSION (r191699): Contextual menu in Mail compose view doesn’t include any of the standard submenus
     4        https://bugs.webkit.org/show_bug.cgi?id=163492
     5        <rdar://problem/28654799>
     6
     7        Reviewed by Darin Adler.
     8
     9        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     10        * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm: Added.
     11        (-[ContextMenuDefaultItemsHaveTagsDelegate webView:didFinishLoadForFrame:]):
     12        (TestWebKitAPI::TEST):
     13
    1142016-10-15  Daniel Bates  <dabates@apple.com>
    215
  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r207340 r207385  
    100100                37DC6791140D7D7600ABCCDB /* DOMRangeOfString.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 37DC678F140D7D3A00ABCCDB /* DOMRangeOfString.html */; };
    101101                37E1064C1697681800B78BD0 /* DOMHTMLTableCellElementCellAbove.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 37E1064B169767F700B78BD0 /* DOMHTMLTableCellElementCellAbove.html */; };
     102                37FB72971DB2E82F00E41BE4 /* ContextMenuDefaultItemsHaveTags.mm in Sources */ = {isa = PBXBuildFile; fileRef = 37FB72951DB2E82F00E41BE4 /* ContextMenuDefaultItemsHaveTags.mm */; };
    102103                3FBD1B4A1D3D66AB00E6D6FA /* FullscreenLayoutConstraints.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = 3FBD1B491D39D1DB00E6D6FA /* FullscreenLayoutConstraints.html */; };
    103104                46C519DA1D355AB200DAA51A /* LocalStorageNullEntries.mm in Sources */ = {isa = PBXBuildFile; fileRef = 46C519D81D355A7300DAA51A /* LocalStorageNullEntries.mm */; };
     
    850851                37E1064B169767F700B78BD0 /* DOMHTMLTableCellElementCellAbove.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = DOMHTMLTableCellElementCellAbove.html; sourceTree = "<group>"; };
    851852                37E38C33169B7D010084C28C /* WebViewDidRemoveFrameFromHierarchy.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebViewDidRemoveFrameFromHierarchy.mm; sourceTree = "<group>"; };
     853                37FB72951DB2E82F00E41BE4 /* ContextMenuDefaultItemsHaveTags.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ContextMenuDefaultItemsHaveTags.mm; sourceTree = "<group>"; };
    852854                3F1B52681D3D7129008D60C4 /* FullscreenLayoutConstraints.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FullscreenLayoutConstraints.mm; sourceTree = "<group>"; };
    853855                3FBD1B491D39D1DB00E6D6FA /* FullscreenLayoutConstraints.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = FullscreenLayoutConstraints.html; sourceTree = "<group>"; };
     
    19121914                                A1146A8A1D2D704F000FE710 /* ContentFiltering.mm */,
    19131915                                5142B2701517C88B00C32B19 /* ContextMenuCanCopyURL.mm */,
     1916                                37FB72951DB2E82F00E41BE4 /* ContextMenuDefaultItemsHaveTags.mm */,
    19141917                                3776BC62150946BC0043A66D /* DeviceScaleFactorInDashboardRegions.mm */,
    19151918                                939BA91614103412001A01BD /* DeviceScaleFactorOnBack.mm */,
     
    23482351                                7CCE7EAC1A411A3400447C4C /* Counters.cpp in Sources */,
    23492352                                2D1C04A71D76298B000A6816 /* TestNavigationDelegate.mm in Sources */,
     2353                                37FB72971DB2E82F00E41BE4 /* ContextMenuDefaultItemsHaveTags.mm in Sources */,
    23502354                                7CCE7EDB1A411A9200447C4C /* CSSParser.cpp in Sources */,
    23512355                                7CCE7F291A411B1000447C4C /* CustomProtocolsInvalidScheme.mm in Sources */,
Note: See TracChangeset for help on using the changeset viewer.