Changeset 207390 in webkit


Ignore:
Timestamp:
Oct 16, 2016 2:27:44 AM (7 years ago)
Author:
Carlos Garcia Campos
Message:

Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.

After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
g_assert_cmpstr for tests.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextLanguages):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r207389 r207390  
     12016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
     2
     3        Unreviewed. Fix GTK+ unit test /webkit2/WebKitWebContext/languages after r206949.
     4
     5        After r206949 navigator.language returns en-US instead of en-us. Language tags in Accept-Language header are
     6        actually case-insensitive, so we should actually do case-insensitive comparisons, but we only have
     7        g_assert_cmpstr for tests.
     8
     9        * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
     10        (testWebContextLanguages):
     11
    1122016-10-16  Carlos Garcia Campos  <cgarcia@igalia.com>
    213
  • trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp

    r206304 r207390  
    466466static void testWebContextLanguages(WebViewTest* test, gconstpointer)
    467467{
    468     static const char* expectedDefaultLanguage = "en-us";
     468    static const char* expectedDefaultLanguage = "en-US";
    469469    test->loadURI(kServer->getURIForPath("/").data());
    470470    test->waitUntilLoadFinished();
     
    497497    g_assert(!error);
    498498    GUniquePtr<char> locale(WebViewTest::javascriptResultToCString(javascriptResult));
    499     g_assert_cmpstr(locale.get(), ==, "en-US");
     499    g_assert_cmpstr(locale.get(), ==, expectedDefaultLanguage);
    500500
    501501    // When using the POSIX locale, en-US should be used as default.
     
    506506    g_assert(!error);
    507507    locale.reset(WebViewTest::javascriptResultToCString(javascriptResult));
    508     g_assert_cmpstr(locale.get(), ==, "en-US");
     508    g_assert_cmpstr(locale.get(), ==, expectedDefaultLanguage);
    509509
    510510    // An invalid locale should throw an exception.
Note: See TracChangeset for help on using the changeset viewer.