Changeset 207426 in webkit
- Timestamp:
- Oct 17, 2016 1:38:46 PM (7 years ago)
- Location:
- trunk/Source
- Files:
-
- 18 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r207423 r207426 1 2016-10-17 Chris Dumez <cdumez@apple.com> 2 3 Move form.reportValidity() behind InteractiveFormValidation setting 4 https://bugs.webkit.org/show_bug.cgi?id=163550 5 6 Reviewed by Darin Adler. 7 8 Move form.reportValidity() behind InteractiveFormValidation setting for consistency 9 given that the two features are strongly related. 10 11 Also enable the setting by default so we can get feedback on the implementation. 12 13 Demos: 14 - Interactive form validation: http://jsfiddle.net/tj_vantoll/HdSqt/ 15 - Report validity: https://googlechrome.github.io/samples/report-validity/ 16 17 * bindings/generic/RuntimeEnabledFeatures.h: 18 (WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled): 19 (WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled): 20 * html/HTMLButtonElement.idl: 21 * html/HTMLFieldSetElement.idl: 22 * html/HTMLFormElement.idl: 23 * html/HTMLInputElement.idl: 24 * html/HTMLKeygenElement.idl: 25 * html/HTMLObjectElement.idl: 26 * html/HTMLOutputElement.idl: 27 * html/HTMLSelectElement.idl: 28 * html/HTMLTextAreaElement.idl: 29 1 30 2016-10-17 Antoine Quint <graouts@apple.com> 2 31 -
trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
r206296 r207426 199 199 bool shadowDOMEnabled() const { return m_isShadowDOMEnabled; } 200 200 201 void setInteractiveFormValidationEnabled(bool isEnabled) { m_isInteractiveFormValidationEnabled = isEnabled; } 202 bool interactiveFormValidationEnabled() const { return m_isInteractiveFormValidationEnabled; } 203 201 204 #if ENABLE(CUSTOM_ELEMENTS) 202 205 void setCustomElementsEnabled(bool areEnabled) { m_areCustomElementsEnabled = areEnabled; } … … 319 322 bool m_isShadowDOMEnabled; 320 323 324 bool m_isInteractiveFormValidationEnabled { false }; 325 321 326 #if ENABLE(CUSTOM_ELEMENTS) 322 327 bool m_areCustomElementsEnabled; -
trunk/Source/WebCore/html/HTMLButtonElement.idl
r207380 r207426 38 38 readonly attribute DOMString validationMessage; 39 39 boolean checkValidity(); 40 boolean reportValidity();40 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 41 41 void setCustomValidity(DOMString? error); 42 42 -
trunk/Source/WebCore/html/HTMLFieldSetElement.idl
r207380 r207426 31 31 readonly attribute DOMString validationMessage; 32 32 boolean checkValidity(); 33 boolean reportValidity();33 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 34 34 void setCustomValidity(DOMString? error); 35 35 }; -
trunk/Source/WebCore/html/HTMLFormElement.idl
r207380 r207426 48 48 void reset(); 49 49 boolean checkValidity(); 50 boolean reportValidity();50 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 51 51 52 52 [Conditional=REQUEST_AUTOCOMPLETE] void requestAutocomplete(); -
trunk/Source/WebCore/html/HTMLInputElement.idl
r207380 r207426 72 72 readonly attribute DOMString validationMessage; 73 73 boolean checkValidity(); 74 boolean reportValidity();74 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 75 75 void setCustomValidity(DOMString? error); 76 76 -
trunk/Source/WebCore/html/HTMLKeygenElement.idl
r207380 r207426 43 43 readonly attribute DOMString validationMessage; 44 44 boolean checkValidity(); 45 boolean reportValidity();45 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 46 46 void setCustomValidity(DOMString? error); 47 47 -
trunk/Source/WebCore/html/HTMLObjectElement.idl
r207380 r207426 45 45 readonly attribute DOMString validationMessage; 46 46 boolean checkValidity(); 47 boolean reportValidity();47 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 48 48 void setCustomValidity(DOMString? error); 49 49 -
trunk/Source/WebCore/html/HTMLOutputElement.idl
r207380 r207426 37 37 readonly attribute DOMString validationMessage; 38 38 boolean checkValidity(); 39 boolean reportValidity();39 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 40 40 void setCustomValidity(DOMString? error); 41 41 -
trunk/Source/WebCore/html/HTMLSelectElement.idl
r207380 r207426 60 60 readonly attribute DOMString validationMessage; 61 61 boolean checkValidity(); 62 boolean reportValidity();62 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 63 63 void setCustomValidity(DOMString? error); // FIXME: Argument should not be nullable. 64 64 -
trunk/Source/WebCore/html/HTMLTextAreaElement.idl
r207380 r207426 44 44 readonly attribute DOMString validationMessage; 45 45 boolean checkValidity(); 46 boolean reportValidity();46 [EnabledAtRuntime=InteractiveFormValidation] boolean reportValidity(); 47 47 void setCustomValidity(DOMString? error); 48 48 -
trunk/Source/WebKit/mac/ChangeLog
r207422 r207426 1 2016-10-17 Chris Dumez <cdumez@apple.com> 2 3 Move form.reportValidity() behind InteractiveFormValidation setting 4 https://bugs.webkit.org/show_bug.cgi?id=163550 5 6 Reviewed by Darin Adler. 7 8 Enable InteractiveFormValidation setting by default and link it to 9 RuntimeEnabledFeatures so we can use it in the IDL. 10 11 * WebView/WebView.mm: 12 (-[WebView _preferencesChanged:]): 13 * WebView/WebViewData.mm: 14 (-[WebViewPrivate init]): 15 1 16 2016-10-17 Anders Carlsson <andersca@apple.com> 2 17 -
trunk/Source/WebKit/mac/WebView/WebView.mm
r207352 r207426 2538 2538 RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled([preferences shadowDOMEnabled]); 2539 2539 2540 RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled([self interactiveFormValidationEnabled]); 2541 2540 2542 RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled([preferences DOMIteratorEnabled]); 2541 2543 -
trunk/Source/WebKit/mac/WebView/WebViewData.mm
r199846 r207426 144 144 zoomsTextOnly = NO; 145 145 146 interactiveFormValidationEnabled = NO;146 interactiveFormValidationEnabled = YES; 147 147 // The default value should be synchronized with WebCore/page/Settings.cpp. 148 148 validationMessageTimerMagnification = 50; -
trunk/Source/WebKit2/ChangeLog
r207424 r207426 1 2016-10-17 Chris Dumez <cdumez@apple.com> 2 3 Move form.reportValidity() behind InteractiveFormValidation setting 4 https://bugs.webkit.org/show_bug.cgi?id=163550 5 6 Reviewed by Darin Adler. 7 8 Enable InteractiveFormValidation setting by default and link it to 9 RuntimeEnabledFeatures so we can use it in the IDL. 10 11 * UIProcess/API/C/WKPreferencesRefPrivate.h: 12 * WebProcess/WebPage/WebPage.cpp: 13 (WebKit::WebPage::updatePreferences): 14 1 15 2016-10-17 Gavin Barraclough <barraclough@apple.com> 2 16 -
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
r207402 r207426 180 180 macro(ArtificialPluginInitializationDelayEnabled, artificialPluginInitializationDelayEnabled, Bool, bool, false, "", "") \ 181 181 macro(TabToLinksEnabled, tabToLinksEnabled, Bool, bool, false, "", "") \ 182 macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, false, "", "") \182 macro(InteractiveFormValidationEnabled, interactiveFormValidationEnabled, Bool, bool, true, "", "") \ 183 183 macro(ScrollingPerformanceLoggingEnabled, scrollingPerformanceLoggingEnabled, Bool, bool, false, "", "") \ 184 184 macro(ScrollAnimatorEnabled, scrollAnimatorEnabled, Bool, bool, DEFAULT_WEBKIT_SCROLL_ANIMATOR_ENABLED, "", "") \ -
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
r204852 r207426 244 244 WK_EXPORT bool WKPreferencesGetTabToLinksEnabled(WKPreferencesRef preferencesRef); 245 245 246 // Defaults to false246 // Defaults to true 247 247 WK_EXPORT void WKPreferencesSetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef, bool enabled); 248 248 WK_EXPORT bool WKPreferencesGetInteractiveFormValidationEnabled(WKPreferencesRef preferencesRef); -
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
r207424 r207426 3198 3198 RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(store.getBoolValueForKey(WebPreferencesKey::shadowDOMEnabledKey())); 3199 3199 3200 RuntimeEnabledFeatures::sharedFeatures().setInteractiveFormValidationEnabled(store.getBoolValueForKey(WebPreferencesKey::interactiveFormValidationEnabledKey())); 3201 3200 3202 RuntimeEnabledFeatures::sharedFeatures().setDOMIteratorEnabled(store.getBoolValueForKey(WebPreferencesKey::domIteratorEnabledKey())); 3201 3203
Note: See TracChangeset
for help on using the changeset viewer.