Changeset 207439 in webkit

Timestamp:

Oct 17, 2016 3:56:15 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Enable keyboard in fullscreen.
​https://bugs.webkit.org/show_bug.cgi?id=163146

Patch by Jeremy Jones <​jeremyj@apple.com> on 2016-10-17
Reviewed by Jer Noble.

Allow keyboard in fullscreen.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView _supportsFullScreenForElement:withKeyboard:]):

Source/WebKit2:

• UIProcess/WebFullScreenManagerProxy.cpp:

(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

Location:

trunk/Source

Files:

• WebKit/mac/ChangeLog (modified) (1 diff)
• WebKit/mac/WebView/WebView.mm (modified) (1 diff)
• WebKit2/ChangeLog (modified) (1 diff)
• WebKit2/UIProcess/WebFullScreenManagerProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-10-17  Jeremy Jones  <jeremyj@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * WebView/WebView.mm:
+        (-[WebView _supportsFullScreenForElement:withKeyboard:]):
+
 2016-10-17  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -8660 +8660 @@
         return NO;
 
-    return !withKeyboard;
+    return true;
 }
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-10-17  Jeremy Jones  <jeremyj@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * UIProcess/WebFullScreenManagerProxy.cpp:
+        (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
+
 2016-10-17  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp

@@ -87 +87 @@
 void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)
 {
-    supports = !withKeyboard;
+    supports = true;
 }