Changeset 207473 in webkit

Timestamp:

Oct 18, 2016 11:08:16 AM (8 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
​https://bugs.webkit.org/show_bug.cgi?id=163583
<rdar://problem/28815882>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-18
Reviewed by Timothy Hatcher.

• UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
Revert logic change introduced by r201171 with no explanation.
Whenever we get a start time we should use it, regardless of
of what the current time is, precisely because the backend is
informing us of the start time to use.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineRecordingContentView.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-10-18  Joseph Pecoraro  <pecoraro@apple.com>
+
+        REGRESSION(r201171): Web Inspector: Timeline Recording playhead should always start immediately, not wait until first event
+        https://bugs.webkit.org/show_bug.cgi?id=163583
+        <rdar://problem/28815882>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/TimelineRecordingContentView.js:
+        (WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
+        Revert logic change introduced by r201171 with no explanation.
+        Whenever we get a start time we should use it, regardless of
+        of what the current time is, precisely because the backend is
+        informing us of the start time to use.
+
 2016-10-17  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

@@ -440 +440 @@
             return;
 
-        if (typeof startTime === "number" && !isNaN(this._currentTime))
+        if (typeof startTime === "number")
             this._currentTime = startTime;
-        else {
+        else if (!isNaN(this._currentTime)) {
             // This happens when you stop and later restart recording.
             // COMPATIBILITY (iOS 9): Timeline.recordingStarted events did not include a timestamp.