Changeset 207483 in webkit

Timestamp:

Oct 18, 2016 1:30:53 PM (8 years ago)

Author:

Wenson Hsieh

Message:

Showing and hiding candidates list is very distracting after selecting word
​https://bugs.webkit.org/show_bug.cgi?id=163609
<rdar://problem/28747712>

Reviewed by Tim Horton.

Introduce WebView hooks for mousedown and mouseup. See radar for more details.

• WebView/WebHTMLView.mm:

(-[WebHTMLView mouseDown:mouseDown:]):
(-[WebHTMLView mouseUp:mouseUp:]):

• WebView/WebView.mm:

(-[WebView prepareForMouseDown]):
(-[WebView prepareForMouseUp]):

• WebView/WebViewInternal.h:

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebHTMLView.mm (modified) (2 diffs)
• WebView/WebView.mm (modified) (1 diff)
• WebView/WebViewInternal.h (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-10-18  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Showing and hiding candidates list is very distracting after selecting word
+        https://bugs.webkit.org/show_bug.cgi?id=163609
+        <rdar://problem/28747712>
+
+        Reviewed by Tim Horton.
+
+        Introduce WebView hooks for mousedown and mouseup. See radar for more details.
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView mouseDown:mouseDown:]):
+        (-[WebHTMLView mouseUp:mouseUp:]):
+        * WebView/WebView.mm:
+        (-[WebView prepareForMouseDown]):
+        (-[WebView prepareForMouseUp]):
+        * WebView/WebViewInternal.h:
+
 2016-10-17  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

@@ -4503 +4503 @@
 #endif
 {
+    [[self _webView] prepareForMouseDown];
+
 #if !PLATFORM(IOS)
     // There's a chance that responding to this event will run a nested event loop, and
@@ -4722 +4724 @@
 #endif
 {
+    [[self _webView] prepareForMouseUp];
+
 #if !PLATFORM(IOS)
     // There's a chance that responding to this event will run a nested event loop, and

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -6753 +6753 @@
 }
 
+- (void)prepareForMouseDown
+{
+}
+
+- (void)prepareForMouseUp
+{
+}
+
 - (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock
 {

trunk/Source/WebKit/mac/WebView/WebViewInternal.h

@@ -297 +297 @@
 
 @interface WebView (WebUpdateWebViewAdditions)
+- (void)prepareForMouseUp;
+- (void)prepareForMouseDown;
 - (void)updateWebViewAdditions;
 - (void)webViewAdditionsWillDestroyView;