Changeset 208825 in webkit


Ignore:
Timestamp:
Nov 16, 2016 4:35:32 PM (7 years ago)
Author:
Brent Fulgham
Message:

Clear track client when removing a track
​https://bugs.webkit.org/show_bug.cgi?id=164842
<rdar://problem/29213621>

Reviewed by Eric Carlson.

Source/WebCore:

Call 'clearClient' when removing a track from an HTMLMediaElement.

Test: media/track/audio-track-add-remove.html

media/track/video-track-add-remove.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::removeAudioTrack): Call 'clearClient'
(WebCore::HTMLMediaElement::removeVideoTrack): Ditto.

LayoutTests:

  • media/track/audio-track-add-remove-expected.txt: Added.
  • media/track/audio-track-add-remove.html: Added.
  • media/track/video-track-add-remove-expected.txt: Added.
  • media/track/video-track-add-remove.html: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r208824 r208825  
     12016-11-16  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Clear track client when removing a track
     4        https://bugs.webkit.org/show_bug.cgi?id=164842
     5        <rdar://problem/29213621>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * media/track/audio-track-add-remove-expected.txt: Added.
     10        * media/track/audio-track-add-remove.html: Added.
     11        * media/track/video-track-add-remove-expected.txt: Added.
     12        * media/track/video-track-add-remove.html: Added.
     13
    1142016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r208824 r208825  
     12016-11-16  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Clear track client when removing a track
     4        https://bugs.webkit.org/show_bug.cgi?id=164842
     5        <rdar://problem/29213621>
     6
     7        Reviewed by Eric Carlson.
     8
     9        Call 'clearClient' when removing a track from an HTMLMediaElement.
     10
     11        Test: media/track/audio-track-add-remove.html
     12              media/track/video-track-add-remove.html
     13
     14        * html/HTMLMediaElement.cpp:
     15        (WebCore::HTMLMediaElement::removeAudioTrack): Call 'clearClient'
     16        (WebCore::HTMLMediaElement::removeVideoTrack): Ditto.
     17
    1182016-11-16  Yusuke Suzuki  <utatane.tea@gmail.com>
    219

  • trunk/Source/WebCore/html/HTMLMediaElement.cpp

    r208729 r208825  
    35753575{
    35763576    m_audioTracks->remove(track);
     3577    track.clearClient();
    35773578}
    35783579
    … …  
    35923593{
    35933594    m_videoTracks->remove(track);
     3595    track.clearClient();
    35943596}
    35953597
Note: See TracChangeset for help on using the changeset viewer.