Changeset 209187 in webkit


Ignore:
Timestamp:
Dec 1, 2016 10:41:08 AM (7 years ago)
Author:
graouts@webkit.org
Message:

[Modern Media Controls] Promote the "on" property from AirPlayButton to IconButton
​https://bugs.webkit.org/show_bug.cgi?id=165260

Reviewed by NOBODY (OOPS!).

With the fix for ​https://bugs.webkit.org/show_bug.cgi?id=165239 we now set the "on"
property for the TracksButton as well, so it makes sense to provide that property
for all IconButton subclasses, not just AirplayButton.

Test: media/modern-media-controls/icon-button/icon-button-on.html

  • Modules/modern-media-controls/controls/airplay-button.css:

(button.airplay.on):

  • Modules/modern-media-controls/controls/airplay-button.js:

(AirplayButton):
(AirplayButton.prototype.get on): Deleted.
(AirplayButton.prototype.set on): Deleted.

  • Modules/modern-media-controls/controls/icon-button.css:

(button.icon:active,):
(button.icon:active): Deleted.

  • Modules/modern-media-controls/controls/icon-button.js:

(IconButton.prototype.get on):
(IconButton.prototype.set on):

Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r209186 r209187  
     12016-12-01  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Promote the "on" property from AirPlayButton to IconButton
     4        https://bugs.webkit.org/show_bug.cgi?id=165260
     5
     6        Reviewed by Dean Jackson.
     7
     8        New test for the "on" property on IconButton.
     9
     10        * media/modern-media-controls/airplay-button/airplay-button-on.html:
     11        * media/modern-media-controls/icon-button/icon-button-on-expected.txt: Added.
     12        * media/modern-media-controls/icon-button/icon-button-on.html: Added.
     13
    1142016-12-01  Antoine Quint  <graouts@apple.com>
    215

  • trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button-on.html

    r207015 r209187  
    1 <link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.css" type="text/css" media="screen">
    2 <link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.css" type="text/css" media="screen">
    3 <link rel="stylesheet" href="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.css" type="text/css" media="screen">
    41<script src="../../../resources/js-test-pre.js"></script>
    5 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/scheduler.js" type="text/javascript"></script>
    6 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-node.js" type="text/javascript"></script>
    7 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/layout-item.js" type="text/javascript"></script>
    8 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/button.js" type="text/javascript"></script>
    9 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-service.js" type="text/javascript"></script>
    10 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/icon-button.js" type="text/javascript"></script>
    11 <script src="../../../../Source/WebCore/Modules/modern-media-controls/controls/airplay-button.js" type="text/javascript"></script>
     2<script src="../resources/media-controls-loader.js" type="text/javascript"></script>
    123<body>
    134<script type="text/javascript">

  • trunk/Source/WebCore/ChangeLog

    r209184 r209187  
     12016-12-01  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Promote the "on" property from AirPlayButton to IconButton
     4        https://bugs.webkit.org/show_bug.cgi?id=165260
     5
     6        Reviewed by Dean Jackson.
     7
     8        With the fix for https://bugs.webkit.org/show_bug.cgi?id=165239 we now set the "on"
     9        property for the TracksButton as well, so it makes sense to provide that property
     10        for all IconButton subclasses, not just AirplayButton.
     11
     12        Test: media/modern-media-controls/icon-button/icon-button-on.html
     13
     14        * Modules/modern-media-controls/controls/airplay-button.css:
     15        (button.airplay.on):
     16        * Modules/modern-media-controls/controls/airplay-button.js:
     17        (AirplayButton):
     18        (AirplayButton.prototype.get on): Deleted.
     19        (AirplayButton.prototype.set on): Deleted.
     20        * Modules/modern-media-controls/controls/icon-button.css:
     21        (button.icon:active,):
     22        (button.icon:active): Deleted.
     23        * Modules/modern-media-controls/controls/icon-button.js:
     24        (IconButton.prototype.get on):
     25        (IconButton.prototype.set on):
     26
    1272016-11-30  Sam Weinig  <sam@webkit.org>
    228

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/airplay-button.css

    r207015 r209187  
    2525
    2626button.airplay.on {
    27     background-color: -apple-wireless-playback-target-active;
     27    background-color: -apple-wireless-playback-target-active !important;
    2828}

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/airplay-button.js

    r208254 r209187  
    3636    }
    3737
    38     // Public
    39 
    40     get on()
    41     {
    42         return this.element.classList.contains("on");
    43     }
    44 
    45     set on(flag) {
    46         this.element.classList.toggle("on", flag);
    47     }
    48 
    4938}

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-button.css

    r206864 r209187  
    2828}
    2929
    30 button.icon:active {
    31     background-color: white;
     30button.icon:active,
     31button.icon.on {
     32    background-color: white !important;
    3233}

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-button.js

    r208448 r209187  
    6767    }
    6868
     69    get on()
     70    {
     71        return this.element.classList.contains("on");
     72    }
     73
     74    set on(flag) {
     75        this.element.classList.toggle("on", flag);
     76    }
     77
    6978    // Protected
    7079
Note: See TracChangeset for help on using the changeset viewer.