Changeset 209194 in webkit


Ignore:
Timestamp:
Dec 1, 2016 1:10:16 PM (7 years ago)
Author:
graouts@webkit.org
Message:

[Modern Media Controls] Turn off text selection
​https://bugs.webkit.org/show_bug.cgi?id=165261

Reviewed by Dean Jackson.

We turn off text selection and force a non-text cursor for all text in media controls.

Tests: media/modern-media-controls/airplay-placard/airplay-placard-text-section.html

media/modern-media-controls/pip-placard/pip-placard-text-section.html
media/modern-media-controls/status-label/status-label-text-selection.html

  • Modules/modern-media-controls/controls/media-controls.css:

(.media-controls):

Location:
trunk
Files:
6 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r209193 r209194  
     12016-12-01  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Turn off text selection
     4        https://bugs.webkit.org/show_bug.cgi?id=165261
     5
     6        Reviewed by Dean Jackson.
     7
     8        New tests to check that text selection is turned off for StatusLabel, AirplayPlacard and PiPPlacard.
     9
     10        * media/modern-media-controls/airplay-placard/airplay-placard-text-section-expected.txt: Added.
     11        * media/modern-media-controls/airplay-placard/airplay-placard-text-section.html: Added.
     12        * media/modern-media-controls/pip-placard/pip-placard-text-section-expected.txt: Added.
     13        * media/modern-media-controls/pip-placard/pip-placard-text-section.html: Added.
     14        * media/modern-media-controls/status-label/status-label-text-selection-expected.txt: Added.
     15        * media/modern-media-controls/status-label/status-label-text-selection.html: Added.
     16
    1172016-12-01  Chris Dumez  <cdumez@apple.com>
    218

  • trunk/Source/WebCore/ChangeLog

    r209193 r209194  
     12016-12-01  Antoine Quint  <graouts@apple.com>
     2
     3        [Modern Media Controls] Turn off text selection
     4        https://bugs.webkit.org/show_bug.cgi?id=165261
     5
     6        Reviewed by Dean Jackson.
     7
     8        We turn off text selection and force a non-text cursor for all text in media controls.
     9
     10        Tests: media/modern-media-controls/airplay-placard/airplay-placard-text-section.html
     11               media/modern-media-controls/pip-placard/pip-placard-text-section.html
     12               media/modern-media-controls/status-label/status-label-text-selection.html
     13
     14        * Modules/modern-media-controls/controls/media-controls.css:
     15        (.media-controls):
     16
    1172016-12-01  Chris Dumez  <cdumez@apple.com>
    218

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/media-controls.css

    r209182 r209194  
    3333    position: relative;
    3434    font-family: -apple-system;
     35    -webkit-user-select: none;
     36    cursor: default;
    3537}
    3638
Note: See TracChangeset for help on using the changeset viewer.