Changeset 209215 in webkit

Timestamp:

Dec 1, 2016 2:48:55 PM (7 years ago)

Author:

Chris Dumez

Message:

Source/WebKit2:
[iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp
​https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>

Reviewed by Simon Fraser.

Tapping an element generates a 'click' event that has 0 as timeStamp
instead of having a proper timeStamp value. This is breaking some
sites.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):

LayoutTests:
[iOS] Tapping an element generates a 'click' event that has 0 as timeStamp
​https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>

Reviewed by Simon Fraser.

Add layout test coverage.

• fast/events/ios/click-event-timestamp-expected.txt: Added.
• fast/events/ios/click-event-timestamp.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/ios/click-event-timestamp-expected.txt (added)
• LayoutTests/fast/events/ios/click-event-timestamp.html (added)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-12-01  Chris Dumez  <cdumez@apple.com>
+
+        [iOS] Tapping an element generates a 'click' event that has 0 as timeStamp
+        https://bugs.webkit.org/show_bug.cgi?id=165270
+        <rdar://problem/29224355>
+
+        Reviewed by Simon Fraser.
+
+        Add layout test coverage.
+
+        * fast/events/ios/click-event-timestamp-expected.txt: Added.
+        * fast/events/ios/click-event-timestamp.html: Added.
+
 2016-12-01  Dave Hyatt  <hyatt@apple.com>
 

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-12-01  Chris Dumez  <cdumez@apple.com>
+
+        [iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp
+        https://bugs.webkit.org/show_bug.cgi?id=165270
+        <rdar://problem/29224355>
+
+        Reviewed by Simon Fraser.
+
+        Tapping an element generates a 'click' event that has 0 as timeStamp
+        instead of having a proper timeStamp value. This is breaking some
+        sites.
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::handleSyntheticClick):
+        (WebKit::WebPage::completeSyntheticClick):
+
 2016-12-01  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -523 +523 @@
     WKBeginObservingContentChanges(true);
 
-    mainframe.eventHandler().mouseMoved(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, NoButton, PlatformEvent::MouseMoved, 0, false, false, false, false, 0, WebCore::ForceAtClick, WebCore::NoTap));
+    mainframe.eventHandler().mouseMoved(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, NoButton, PlatformEvent::MouseMoved, 0, false, false, false, false, currentTime(), WebCore::ForceAtClick, WebCore::NoTap));
     mainframe.document()->updateStyleIfNeeded();
 
@@ -570 +570 @@
     bool tapWasHandled = false;
     m_lastInteractionLocation = roundedAdjustedPoint;
-    tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, 0, WebCore::ForceAtClick, syntheticClickType));
-    tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, 0, WebCore::ForceAtClick, syntheticClickType));
+    tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
+    tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
 
     RefPtr<Frame> newFocusedFrame = m_page->focusController().focusedFrame();