Changeset 209224 in webkit

Timestamp:

Dec 1, 2016 5:21:46 PM (7 years ago)

Author:

Simon Fraser

Message:

Put an obvious debug border on layers with backdrop filters
​https://bugs.webkit.org/show_bug.cgi?id=165291

Reviewed by Tim Horton.

Put a wide magenta border on layers with backdrop filters, to highlight their performance impact.

Change the "contents layer" color (used by WebGL, video etc) to blue.

Make the clipping layer border slightly narrower.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getDebugBorderInfo):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setBackdropFilters):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GraphicsLayer.cpp (modified) (2 diffs)
• platform/graphics/ca/GraphicsLayerCA.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-12-01  Simon Fraser  <simon.fraser@apple.com>
+
+        Put an obvious debug border on layers with backdrop filters
+        https://bugs.webkit.org/show_bug.cgi?id=165291
+
+        Reviewed by Tim Horton.
+
+        Put a wide magenta border on layers with backdrop filters, to highlight their performance impact.
+        
+        Change the "contents layer" color (used by WebGL, video etc) to blue.
+        
+        Make the clipping layer border slightly narrower.
+
+        * platform/graphics/GraphicsLayer.cpp:
+        (WebCore::GraphicsLayer::getDebugBorderInfo):
+        * platform/graphics/ca/GraphicsLayerCA.cpp:
+        (WebCore::GraphicsLayerCA::setBackdropFilters):
+
 2016-12-01  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp

@@ -438 +438 @@
 void GraphicsLayer::getDebugBorderInfo(Color& color, float& width) const
 {
+    width = 2;
+
+    if (needsBackdrop()) {
+        color = Color(255, 0, 255, 128); // has backdrop: magenta
+        width = 12;
+        return;
+    }
+    
     if (drawsContent()) {
         if (m_usingTiledBacking) {
             color = Color(255, 128, 0, 128); // tiled layer: orange
-            width = 2;
             return;
         }
 
         color = Color(0, 128, 32, 128); // normal layer: green
-        width = 2;
         return;
     }
 
     if (usesContentsLayer()) {
-        color = Color(255, 150, 255, 200); // non-painting layer with contents: pink
-        width = 2;
+        color = Color(0, 64, 128, 150); // non-painting layer with contents: blue
+        width = 8;
         return;
     }
@@ -458 +464 @@
     if (masksToBounds()) {
         color = Color(128, 255, 255, 48); // masking layer: pale blue
-        width = 20;
+        width = 16;
         return;
     }
 
     color = Color(255, 255, 0, 192); // container: yellow
-    width = 2;
 }
 

trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

@@ -788 +788 @@
     }
 
-    noteLayerPropertyChanged(BackdropFiltersChanged);
+    noteLayerPropertyChanged(BackdropFiltersChanged | DebugIndicatorsChanged);
     return canCompositeFilters;
 }