Changeset 220328 in webkit


Ignore:
Timestamp:
Aug 6, 2017 8:24:50 PM (7 years ago)
Author:
Ryan Haddad
Message:

Unreviewed, rolling out r220295.

This change introduced 4 errors in webkitpy tests.

Reverted changeset:

"[XCode] webkit-patch should run sort-Xcode-project-file"
​https://bugs.webkit.org/show_bug.cgi?id=174036
​http://trac.webkit.org/changeset/220295

Location:
trunk/Tools
Files:
1 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r220327 r220328  
     12017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
     2
     3        Unreviewed, rolling out r220295.
     4
     5        This change introduced 4 errors in webkitpy tests.
     6
     7        Reverted changeset:
     8
     9        "[XCode] webkit-patch should run sort-Xcode-project-file"
     10        https://bugs.webkit.org/show_bug.cgi?id=174036
     11        http://trac.webkit.org/changeset/220295
     12
    1132017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
    214

  • trunk/Tools/Scripts/webkitpy/common/config/ports.py

    r220295 r220328  
    135135        return self._append_build_style_flag(command, build_style)
    136136
    137     def run_sort_xcode_project_file_command(self):
    138         return self.script_shell_command("sort-Xcode-project-file")
    139 
    140137
    141138class IOSPort(DeprecatedPort):

  • trunk/Tools/Scripts/webkitpy/tool/commands/download.py

    r220295 r220328  
    128128    help_text = "Prepares a ChangeLog and lands the current working directory diff."
    129129    steps = [
    130         steps.SortXcodeProjectFiles,
    131130        steps.PrepareChangeLog,
    132131        steps.EditChangeLog,

  • trunk/Tools/Scripts/webkitpy/tool/commands/upload.py

    r220295 r220328  
    258258        steps.PromptForBugOrTitle,
    259259        steps.CreateBug,
    260         steps.SortXcodeProjectFiles,
    261260        steps.PrepareChangeLog,
    262261    ]
    … …  
    277276        steps.PromptForBugOrTitle,
    278277        steps.CreateBug,
    279         steps.SortXcodeProjectFiles,
    280278        steps.PrepareChangeLog,
    281279        steps.EditChangeLog,

  • trunk/Tools/Scripts/webkitpy/tool/steps/__init__.py

    r220295 r220328  
    6060from webkitpy.tool.steps.revertrevision import RevertRevision
    6161from webkitpy.tool.steps.runtests import RunTests
    62 from webkitpy.tool.steps.sortxcodeprojectfiles import SortXcodeProjectFiles
    6362from webkitpy.tool.steps.suggestreviewers import SuggestReviewers
    6463from webkitpy.tool.steps.update import Update

  • trunk/Tools/Scripts/webkitpy/tool/steps/options.py

    r220295 r220328  
    5858    review = make_option("--no-review", action="store_false", dest="review", default=True, help="Do not mark the patch for review.")
    5959    reviewer = make_option("-r", "--reviewer", action="store", type="string", dest="reviewer", help="Update ChangeLogs to say Reviewed by REVIEWER.")
    60     sort_xcode_project = make_option("--no-sort-xcode-project", action="store_false", dest="sort_xcode_project", default=True, help="Don't sort modified xcode projects.")
    6160    suggest_reviewers = make_option("--suggest-reviewers", action="store_true", default=False, help="Offer to CC appropriate reviewers.")
    6261    test = make_option("--test", action="store_true", dest="test", default=False, help="Run run-webkit-tests before committing.")
Note: See TracChangeset for help on using the changeset viewer.