Changeset 220330 in webkit


Ignore:
Timestamp:
Aug 7, 2017 12:03:06 AM (7 years ago)
Author:
keith_miller@apple.com
Message:

REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
https://bugs.webkit.org/show_bug.cgi?id=175256

Reviewed by Saam Barati.

The check in createFromBytes just needed to check that the buffer was not null before
calling isCaged.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::createFromBytes):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r220329 r220330  
     12017-08-07  Keith Miller  <keith_miller@apple.com>
     2
     3        REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
     4        https://bugs.webkit.org/show_bug.cgi?id=175256
     5
     6        Reviewed by Saam Barati.
     7
     8        The check in createFromBytes just needed to check that the buffer was not null before
     9        calling isCaged.
     10
     11        * runtime/ArrayBuffer.cpp:
     12        (JSC::ArrayBuffer::createFromBytes):
     13
    1142017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
    215
  • trunk/Source/JavaScriptCore/runtime/ArrayBuffer.cpp

    r220118 r220330  
    199199Ref<ArrayBuffer> ArrayBuffer::createFromBytes(const void* data, unsigned byteLength, ArrayBufferDestructorFunction&& destructor)
    200200{
    201     if (!Gigacage::isCaged(data) && data && byteLength)
     201    if (data && byteLength && !Gigacage::isCaged(data))
    202202        Gigacage::disableGigacage();
    203203   
Note: See TracChangeset for help on using the changeset viewer.