Changeset 220434 in webkit

Timestamp:

Aug 8, 2017 6:24:25 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Created Individual EWS Pages
​https://bugs.webkit.org/show_bug.cgi?id=174477

Patch by obinna obike <​oobike@apple.com> on 2017-08-08
Reviewed by Aakash Jain.

Created individual pages for each EWS. Changed the link within each status bubble
to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.

• QueueStatusServer/handlers/patch.py:

(Patch.get): Handles the case for individual ews queue as well as for all EWS queues.

• QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Updated url for specific EWS.

• QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
• QueueStatusServer/templates/patch.html: Added a link to go directly to the page with

all ews queues.

• QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it

takes you directly to the individual ews page.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• QueueStatusServer/handlers/patch.py (modified) (2 diffs)
• QueueStatusServer/handlers/statusbubble.py (modified) (1 diff)
• QueueStatusServer/main.py (modified) (1 diff)
• QueueStatusServer/templates/patch.html (modified) (2 diffs)
• QueueStatusServer/templates/statusbubble.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-08-08  obinna obike  <oobike@apple.com>
+
+        Created Individual EWS Pages
+        https://bugs.webkit.org/show_bug.cgi?id=174477
+
+        Reviewed by Aakash Jain.
+
+        Created individual pages for each EWS. Changed the link within each status bubble
+        to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
+
+        * QueueStatusServer/handlers/patch.py:
+        (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
+        * QueueStatusServer/handlers/statusbubble.py:
+        (StatusBubble._build_bubble): Updated url for specific EWS.
+        * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
+        * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
+        all ews queues.
+        * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
+        takes you directly to the individual ews page.
+
 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
 

trunk/Tools/QueueStatusServer/handlers/patch.py

@@ -34 +34 @@
 
 class Patch(webapp.RequestHandler):
-    def get(self, attachment_id_string):
+    def get(self, attachment_id_string, queue_name=None):
         attachment_id = int(attachment_id_string)
         statuses = QueueStatus.all().filter("active_patch_id =", attachment_id).order("-date")
@@ -42 +42 @@
         for status in statuses:
             bug_id = status.active_bug_id # Should be the same for every status.
-            per_queue_statuses = queue_status.get(status.queue_name, [])
-            per_queue_statuses.append(status)
-            queue_status[status.queue_name] = per_queue_statuses
+            if status.queue_name == queue_name or queue_name is None:
+                per_queue_statuses = queue_status.get(status.queue_name, [])
+                per_queue_statuses.append(status)
+                queue_status[status.queue_name] = per_queue_statuses
         queue_status = sorted(queue_status.items())
         template_values = {

trunk/Tools/QueueStatusServer/handlers/statusbubble.py

@@ -114 +114 @@
             "name": queue.short_name().lower(),
             "attachment_id": attachment.id,
+            "queue_name": queue.name(),
         }
         # 10 recent statuses is enough to always include a resultative one, if there were any at all.

trunk/Tools/QueueStatusServer/main.py

@@ -65 +65 @@
     ('/sync-queue-logs', SyncQueueLogs),
     (r'/patch-status/(.*)/(.*)', PatchStatus),
+    (r'/patch/(.*)/(.*)', Patch),
     (r'/patch/(.*)', Patch),
     ('/submit-to-ews', SubmitToEWS),

trunk/Tools/QueueStatusServer/templates/patch.html

@@ -8 +8 @@
 <h1>
   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
-</h1>{% for queue_name, statuses in queue_status %}
+</h1>
+{% if queue_status|length == 0 %}
+<p>Waiting in Queue, Processing has not started yet.</p>
+{% endif %}
+{% for queue_name, statuses in queue_status %}
 <div class="status-details">
   <h2>{{ queue_name }}</h2>
@@ -20 +24 @@
   </ul>
 </div>{% endfor %}
+{% if queue_status|length <= 1 %}
+<br>
+<a href="/patch/{{ attachment_id }}">All EWS Queues</a>
+{% endif %}
 </html>

trunk/Tools/QueueStatusServer/templates/statusbubble.html

@@ -78 +78 @@
   {% for bubble in bubbles %}
   <a class="status {{ bubble.state }}" target="_top"
-      href="/patch/{{ bubble.attachment_id }}"
+      href="/patch/{{ bubble.attachment_id }}/{{ bubble.queue_name }}"
   {% if bubble.details_message %}
       title="{{ bubble.details_message }}"