Changeset 220439 in webkit
- Timestamp:
- Aug 8, 2017 8:18:25 PM (7 years ago)
- Location:
- branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac/ChangeLog
r219956 r220439 1 2017-08-08 Jason Marcell <jmarcell@apple.com> 2 3 Cherry-pick r220429. rdar://problem/33789343 4 5 2017-08-08 Brady Eidson <beidson@apple.com> 6 7 Don't enable default icon loading in WK1 for apps linked against old SDKs. 8 <rdar://problem/33724060> and https://bugs.webkit.org/show_bug.cgi?id=175342 9 10 Reviewed by Andy Estes. 11 12 * Misc/WebKitVersionChecks.h: 13 * WebCoreSupport/WebFrameLoaderClient.mm: 14 (WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless 15 the app is linked against new WebKit with the new behavior. 16 1 17 2017-07-26 Jason Marcell <jmarcell@apple.com> 2 18 -
branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.h
r219283 r220439 62 62 #define WEBKIT_FIRST_VERSION_WITHOUT_LEGACY_BACKGROUNDSIZE_SHORTHAND_BEHAVIOR 0x02190100 // 537.1.0 63 63 #define WEBKIT_FIRST_VERSION_WITH_INSECURE_CONTENT_BLOCKING 0x02590116 // 601.1.22 64 #define WEBKIT_FIRST_VERSION_WITH_DEFAULT_ICON_LOADING 0x025C0126 // 604.1.38 65 64 66 #else 65 67 // <rdar://problem/6627758> Need to implement WebKitLinkedOnOrAfter -
branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm
r219099 r220439 56 56 #import "WebKitLogging.h" 57 57 #import "WebKitNSStringExtras.h" 58 #import "WebKitVersionChecks.h" 58 59 #import "WebNSURLExtras.h" 59 60 #import "WebNavigationData.h" … … 145 146 #import <WebCore/WAKWindow.h> 146 147 #import <WebCore/WebCoreThreadMessage.h> 147 #import "WebKitVersionChecks.h"148 148 #import "WebMailDelegate.h" 149 149 #import "WebUIKitDelegate.h" … … 2283 2283 ASSERT(documentLoader); 2284 2284 2285 #if PLATFORM(MAC) 2286 if (!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_DEFAULT_ICON_LOADING)) { 2287 for (auto& icon : icons) 2288 documentLoader->didGetLoadDecisionForIcon(false, icon.second, 0); 2289 2290 return; 2291 } 2292 #endif 2293 2285 2294 bool disallowedDueToImageLoadSettings = false; 2286 2295 if (!frame->settings().loadsImagesAutomatically() && !frame->settings().loadsSiteIconsIgnoringImageLoadingSetting())
Note: See TracChangeset
for help on using the changeset viewer.