Changeset 220461 in webkit

Timestamp:

Aug 9, 2017 10:23:16 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer][MSE] Add missing lock around getStreamByTrackId
​https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <​cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-08-09  Charlie Turner  <cturner@igalia.com>
+
+        [GStreamer][MSE] Add missing lock around getStreamByTrackId
+        https://bugs.webkit.org/show_bug.cgi?id=175323
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        Covered by existing tests.
+
+        * platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
+        (WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
+        lock is taken before modifiying the track queues indirectly via the
+        iterator use in getTrackId.
+
 2017-08-09  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp

@@ -489 +489 @@
         GST_TIME_ARGS(WebCore::toGstClockTime(mediaSample->duration().toDouble())));
 
+    WTF::GMutexLocker<GMutex> locker(*GST_OBJECT_GET_LOCK(m_webKitMediaSrc.get()));
     Stream* stream = getStreamByTrackId(m_webKitMediaSrc.get(), trackId);