Changeset 220499 in webkit
- Timestamp:
- Aug 9, 2017 5:35:58 PM (7 years ago)
- Location:
- trunk
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r220481 r220499 1 2017-08-09 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r220466, r220477, and r220487. 4 https://bugs.webkit.org/show_bug.cgi?id=175411 5 6 This change broke existing API tests and follow up fixes did 7 not resolve all the issues. (Requested by ryanhaddad on 8 #webkit). 9 10 Reverted changesets: 11 12 https://bugs.webkit.org/show_bug.cgi?id=175244 13 http://trac.webkit.org/changeset/220466 14 15 "WTF::Function does not allow for reference / non-default 16 constructible return types" 17 https://bugs.webkit.org/show_bug.cgi?id=175244 18 http://trac.webkit.org/changeset/220477 19 20 https://bugs.webkit.org/show_bug.cgi?id=175244 21 http://trac.webkit.org/changeset/220487 22 1 23 2017-08-09 Caitlin Potter <caitp@igalia.com> 2 24 -
trunk/Source/JavaScriptCore/runtime/ArrayBuffer.cpp
r220477 r220499 133 133 other.m_destructor = WTFMove(m_destructor); 134 134 other.m_shared = m_shared; 135 reset();135 clear(); 136 136 } 137 137 -
trunk/Source/WTF/ChangeLog
r220478 r220499 1 2017-08-09 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r220466, r220477, and r220487. 4 https://bugs.webkit.org/show_bug.cgi?id=175411 5 6 This change broke existing API tests and follow up fixes did 7 not resolve all the issues. (Requested by ryanhaddad on 8 #webkit). 9 10 Reverted changesets: 11 12 https://bugs.webkit.org/show_bug.cgi?id=175244 13 http://trac.webkit.org/changeset/220466 14 15 "WTF::Function does not allow for reference / non-default 16 constructible return types" 17 https://bugs.webkit.org/show_bug.cgi?id=175244 18 http://trac.webkit.org/changeset/220477 19 20 https://bugs.webkit.org/show_bug.cgi?id=175244 21 http://trac.webkit.org/changeset/220487 22 1 23 2017-08-09 Sam Weinig <sam@webkit.org> 2 24 -
trunk/Source/WTF/wtf/Function.h
r220477 r220499 53 53 Out operator()(In... in) const 54 54 { 55 ASSERT(m_callableWrapper); 56 return m_callableWrapper->call(std::forward<In>(in)...); 55 if (m_callableWrapper) 56 return m_callableWrapper->call(std::forward<In>(in)...); 57 return Out(); 57 58 } 58 59 -
trunk/Source/WebCore/ChangeLog
r220497 r220499 1 2017-08-09 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r220466, r220477, and r220487. 4 https://bugs.webkit.org/show_bug.cgi?id=175411 5 6 This change broke existing API tests and follow up fixes did 7 not resolve all the issues. (Requested by ryanhaddad on 8 #webkit). 9 10 Reverted changesets: 11 12 https://bugs.webkit.org/show_bug.cgi?id=175244 13 http://trac.webkit.org/changeset/220466 14 15 "WTF::Function does not allow for reference / non-default 16 constructible return types" 17 https://bugs.webkit.org/show_bug.cgi?id=175244 18 http://trac.webkit.org/changeset/220477 19 20 https://bugs.webkit.org/show_bug.cgi?id=175244 21 http://trac.webkit.org/changeset/220487 22 1 23 2017-08-09 Chris Dumez <cdumez@apple.com> 2 24 -
trunk/Source/WebCore/bindings/js/JSCustomElementInterface.h
r220477 r220499 95 95 RefPtr<Element> tryToConstructCustomElement(Document&, const AtomicString&); 96 96 97 void invokeCallback(Element&, JSC::JSObject* callback, const WTF::Function<void(JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&)>& addArguments = [](JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&){ });97 void invokeCallback(Element&, JSC::JSObject* callback, const WTF::Function<void(JSC::ExecState*, JSDOMGlobalObject*, JSC::MarkedArgumentBuffer&)>& addArguments = { }); 98 98 99 99 QualifiedName m_name; -
trunk/Source/WebKit/ChangeLog
r220497 r220499 1 2017-08-09 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r220466, r220477, and r220487. 4 https://bugs.webkit.org/show_bug.cgi?id=175411 5 6 This change broke existing API tests and follow up fixes did 7 not resolve all the issues. (Requested by ryanhaddad on 8 #webkit). 9 10 Reverted changesets: 11 12 https://bugs.webkit.org/show_bug.cgi?id=175244 13 http://trac.webkit.org/changeset/220466 14 15 "WTF::Function does not allow for reference / non-default 16 constructible return types" 17 https://bugs.webkit.org/show_bug.cgi?id=175244 18 http://trac.webkit.org/changeset/220477 19 20 https://bugs.webkit.org/show_bug.cgi?id=175244 21 http://trac.webkit.org/changeset/220487 22 1 23 2017-08-09 Chris Dumez <cdumez@apple.com> 2 24 -
trunk/Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.h
r220477 r220499 61 61 public: 62 62 using UpdateCookiePartitioningForDomainsHandler = WTF::Function<void(const Vector<String>& domainsToRemove, const Vector<String>& domainsToAdd, ShouldClearFirst)>; 63 static Ref<WebResourceLoadStatisticsStore> create(const String& resourceLoadStatisticsDirectory, Function<void (const String&)>&& testingCallback, UpdateCookiePartitioningForDomainsHandler&& updateCookiePartitioningForDomainsHandler = [](const Vector<String>&, const Vector<String>&, ShouldClearFirst){ })63 static Ref<WebResourceLoadStatisticsStore> create(const String& resourceLoadStatisticsDirectory, Function<void (const String&)>&& testingCallback, UpdateCookiePartitioningForDomainsHandler&& updateCookiePartitioningForDomainsHandler = { }) 64 64 { 65 65 return adoptRef(*new WebResourceLoadStatisticsStore(resourceLoadStatisticsDirectory, WTFMove(testingCallback), WTFMove(updateCookiePartitioningForDomainsHandler))); -
trunk/Tools/ChangeLog
r220487 r220499 1 2017-08-09 Commit Queue <commit-queue@webkit.org> 2 3 Unreviewed, rolling out r220466, r220477, and r220487. 4 https://bugs.webkit.org/show_bug.cgi?id=175411 5 6 This change broke existing API tests and follow up fixes did 7 not resolve all the issues. (Requested by ryanhaddad on 8 #webkit). 9 10 Reverted changesets: 11 12 https://bugs.webkit.org/show_bug.cgi?id=175244 13 http://trac.webkit.org/changeset/220466 14 15 "WTF::Function does not allow for reference / non-default 16 constructible return types" 17 https://bugs.webkit.org/show_bug.cgi?id=175244 18 http://trac.webkit.org/changeset/220477 19 20 https://bugs.webkit.org/show_bug.cgi?id=175244 21 http://trac.webkit.org/changeset/220487 22 1 23 2017-08-09 Sam Weinig <sam@webkit.org> 2 24 -
trunk/Tools/TestWebKitAPI/Tests/WTF/Function.cpp
r220487 r220499 141 141 { 142 142 Function<unsigned()> a; 143 EXPECT_FALSE(static_cast<bool>(a)); 144 EXPECT_EQ(0U, a()); 145 143 146 a = [] { 144 147 return 1U; … … 147 150 EXPECT_EQ(1U, a()); 148 151 152 a = nullptr; 153 EXPECT_FALSE(static_cast<bool>(a)); 154 EXPECT_EQ(0U, a()); 155 149 156 a = MoveOnly { 2 }; 150 157 EXPECT_TRUE(static_cast<bool>(a)); … … 169 176 EXPECT_FALSE(static_cast<bool>(c)); 170 177 EXPECT_EQ(0U, c()); 178 179 Function<unsigned()> d = nullptr; 180 EXPECT_FALSE(static_cast<bool>(d)); 181 EXPECT_EQ(0U, d()); 171 182 } 172 183 … … 212 223 213 224 a = FunctionDestructionChecker(a); 225 a = nullptr; 226 EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionAsBool)); 227 EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionResult)); 228 EXPECT_FALSE(FunctionDestructionChecker::functionAsBool.value()); 229 EXPECT_EQ(0U, FunctionDestructionChecker::functionResult.value()); 230 FunctionDestructionChecker::functionAsBool = std::nullopt; 231 FunctionDestructionChecker::functionResult = std::nullopt; 232 233 a = FunctionDestructionChecker(a); 214 234 a = MoveOnly { 2 }; 215 235 EXPECT_TRUE(static_cast<bool>(FunctionDestructionChecker::functionAsBool));
Note: See TracChangeset
for help on using the changeset viewer.