Changeset 220609 in webkit


Ignore:
Timestamp:
Aug 11, 2017 2:08:58 PM (7 years ago)
Author:
Nikita Vasilyev
Message:

Web Inspector: Styles: Update the filter icon to match Xcode
​https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

  • UserInterface/Images/FilterFieldGlyph.svg:

Half-pixel transform is necessary for a cleaner rasterisation.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove vertical-align: bottom,
since it didn't do anything for it.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
  • UserInterface/Views/FilterBar.js:

(WI.FilterBar):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkSidebarPanel.js:

(WI.NetworkSidebarPanel):

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel):

  • UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):

  • Localizations/en.lproj/localizedStrings.js:

Replace placeholder text for all filter fields with "Filter".

Location:
trunk/Source/WebInspectorUI
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r220575 r220609  
     12017-08-11  Nikita Vasilyev  <nvasilyev@apple.com>
     2
     3        Web Inspector: Styles: Update the filter icon to match Xcode
     4        https://bugs.webkit.org/show_bug.cgi?id=175458
     5        <rdar://problem/33838660>
     6
     7        Reviewed by Matt Baker.
     8
     9        * UserInterface/Images/FilterFieldGlyph.svg:
     10        Half-pixel transform is necessary for a cleaner rasterisation.
     11
     12        * UserInterface/Views/FilterBar.css:
     13        (.filter-bar > input[type="search"]::-webkit-search-decoration):       
     14        (.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
     15        ::-webkit-search-decoration is a flexbox item. Remove `vertical-align: bottom`,
     16        since it didn't do anything for it.
     17
     18        * UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
     19        * UserInterface/Views/FilterBar.js:
     20        (WI.FilterBar):       
     21        * UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
     22        (WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
     23        * UserInterface/Views/DebuggerSidebarPanel.js:
     24        * UserInterface/Views/LogContentView.js:
     25        (WI.LogContentView):
     26        * UserInterface/Views/NetworkSidebarPanel.js:
     27        (WI.NetworkSidebarPanel):
     28        * UserInterface/Views/RecordingNavigationSidebarPanel.js:
     29        (WI.RecordingNavigationSidebarPanel):
     30        * UserInterface/Views/ResourceSidebarPanel.js:
     31        (WI.ResourceSidebarPanel):
     32        * UserInterface/Views/SearchSidebarPanel.js:
     33        (WI.SearchSidebarPanel):
     34        * UserInterface/Views/StorageSidebarPanel.js:
     35        (WI.StorageSidebarPanel):
     36        * UserInterface/Views/TimelineRecordingContentView.js:
     37        (WI.TimelineRecordingContentView):
     38        * Localizations/en.lproj/localizedStrings.js:       
     39        Replace placeholder text for all filter fields with "Filter".
     40
    1412017-08-10  Ross Kirsling  <ross.kirsling@sony.com>
    242

  • trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

    r220370 r220609  
    391391localizedStrings["Fill"] = "Fill";
    392392localizedStrings["Fill Mode"] = "Fill Mode";
    393 localizedStrings["Filter Actions"] = "Filter Actions";
    394 localizedStrings["Filter Console Log"] = "Filter Console Log";
    395 localizedStrings["Filter List"] = "Filter List";
    396 localizedStrings["Filter Records"] = "Filter Records";
    397 localizedStrings["Filter Resource List"] = "Filter Resource List";
    398 localizedStrings["Filter Search Results"] = "Filter Search Results";
    399 localizedStrings["Filter Storage List"] = "Filter Storage List";
    400 localizedStrings["Filter Styles"] = "Filter Styles";
     393localizedStrings["Filter"] = "Filter";
    401394localizedStrings["Flexbox"] = "Flexbox";
    402395localizedStrings["Float"] = "Float";

  • trunk/Source/WebInspectorUI/UserInterface/Images/FilterFieldGlyph.svg

    r191693 r220609  
    11<?xml version="1.0" encoding="utf-8"?>
    2 <!-- Copyright © 2014 Apple Inc. All rights reserved. -->
     2<!-- Copyright © 2017 Apple Inc. All rights reserved. -->
    33<svg xmlns="http://www.w3.org/2000/svg" id="root" version="1.1" viewBox="0 0 13 13">
    4     <path fill="rgb(146, 146, 146)" fill-rule="evenodd" d="M 9.964556 7 C 9.987914 6.836699 10 6.669761 10 6.5 C 10 4.567003 8.432997 3 6.5 3 C 4.567003 3 3 4.567003 3 6.5 C 3 6.669761 3.012086 6.836699 3.035444 7 L 9.964556 7 L 9.964556 7 Z M 6.5 13 C 10.08985 13 13 10.089851 13 6.5 C 13 2.91015 10.08985 0 6.5 0 C 2.910149 0 0 2.91015 0 6.5 C 0 10.089851 2.910149 13 6.5 13 L 6.5 13 Z M 6.5 12 C 9.537566 12 12 9.537566 12 6.5 C 12 3.462434 9.537566 1 6.5 1 C 3.462434 1 1 3.462434 1 6.5 C 1 9.537566 3.462434 12 6.5 12 L 6.5 12 Z"/>
     4    <g transform="translate(0.5, 0.5)" stroke="rgb(127, 127, 127)" stroke-width="1" fill="none">
     5        <circle cx="6" cy="6" r="6"/>
     6        <path d="M3 4 L 9 4" stroke-linecap="square"/>
     7        <path d="M4 6 L 8 6" stroke-linecap="square"/>
     8        <path d="M5 8 L 7 8" stroke-linecap="square"/>
     9    </g>
    510</svg>

  • trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js

    r220119 r220609  
    180180
    181181        this._filterBar = new WI.FilterBar;
    182         this._filterBar.placeholder = WI.UIString("Filter Styles");
    183182        this._filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._filterDidChange, this);
    184183        optionsContainer.appendChild(this._filterBar.element);

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.css

    r214843 r220609  
    2626.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter {
    2727    position: relative;
    28     width: 14px;
    29     height: 14px;
     28    width: 13px;
     29    height: 13px;
    3030}
    3131

  • trunk/Source/WebInspectorUI/UserInterface/Views/DebuggerSidebarPanel.js

    r220119 r220609  
    117117        this.suppressFilteringOnTreeElements([this._allExceptionsBreakpointTreeElement, this._allUncaughtExceptionsBreakpointTreeElement, this._assertionsBreakpointTreeElement]);
    118118
    119         this.filterBar.placeholder = WI.UIString("Filter List");
    120 
    121119        function showResourcesWithIssuesOnlyFilterFunction(treeElement)
    122120        {

  • trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.css

    r214066 r220609  
    8383    height: 13px;
    8484
    85     margin-left: 6px;
    86     margin-right: 6px;
     85    margin: 4px 4px 3px 3px;
    8786
    88     vertical-align: bottom;
     87    align-self: center;
    8988
    9089    background-image: url(../Images/FilterFieldGlyph.svg);

  • trunk/Source/WebInspectorUI/UserInterface/Views/FilterBar.js

    r220119 r220609  
    4040        this._inputField = document.createElement("input");
    4141        this._inputField.type = "search";
     42        this._inputField.placeholder = WI.UIString("Filter");
    4243        this._inputField.spellcheck = false;
    4344        this._inputField.incremental = true;

  • trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js

    r220119 r220609  
    6060        const fixed = true;
    6161        this._findBanner = new WI.FindBanner(this, "console-find-banner", fixed);
    62         this._findBanner.inputField.placeholder = WI.UIString("Filter Console Log");
    6362        this._findBanner.targetElement = this.element;
    6463

  • trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js

    r220119 r220609  
    3434        this.contentBrowser = contentBrowser;
    3535
    36         this.filterBar.placeholder = WI.UIString("Filter Resource List");
    37 
    3836        this.contentTreeOutline.element.classList.add("network-grid");
    3937        this.contentTreeOutline.disclosureButtons = false;

  • trunk/Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js

    r220180 r220609  
    3232        this.contentTreeOutline.customIndent = true;
    3333        this.contentTreeOutline.registerScrollVirtualizer(this.contentView.element, 20);
    34 
    35         this.filterBar.placeholder = WI.UIString("Filter Actions");
    3634
    3735        this.recording = null;

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

    r220294 r220609  
    3232        this.contentBrowser = contentBrowser;
    3333
    34         this.filterBar.placeholder = WI.UIString("Filter Resource List");
    35 
    3634        this._navigationBar = new WI.NavigationBar;
    3735        this.addSubview(this._navigationBar);

  • trunk/Source/WebInspectorUI/UserInterface/Views/SearchSidebarPanel.js

    r220119 r220609  
    4646        searchElement.appendChild(this._inputElement);
    4747
    48         this.filterBar.placeholder = WI.UIString("Filter Search Results");
    49 
    5048        this._searchQuerySetting = new WI.Setting("search-sidebar-query", "");
    5149        this._inputElement.value = this._searchQuerySetting.value;

  • trunk/Source/WebInspectorUI/UserInterface/Views/StorageSidebarPanel.js

    r220119 r220609  
    3232        this.contentBrowser = contentBrowser;
    3333
    34         this.filterBar.placeholder = WI.UIString("Filter Storage List");
    35 
    3634        this._navigationBar = new WI.NavigationBar;
    3735        this.addSubview(this._navigationBar);

  • trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js

    r220119 r220609  
    5353
    5454        this._filterBarNavigationItem = new WI.FilterBarNavigationItem;
    55         this._filterBarNavigationItem.filterBar.placeholder = WI.UIString("Filter Records");
    5655        this._filterBarNavigationItem.filterBar.addEventListener(WI.FilterBar.Event.FilterDidChange, this._filterDidChange, this);
    5756        this._timelineContentBrowser.navigationBar.addNavigationItem(this._filterBarNavigationItem);
Note: See TracChangeset for help on using the changeset viewer.