Changeset 227990 in webkit

Timestamp:

Feb 1, 2018 4:40:31 PM (6 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r222824): UI process crashes in WebKit::WebBackForwardList::backItem const
<​https://webkit.org/b/182409>
<rdar://problem/35495094>

Reviewed by Alex Christensen.

• UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::goToItem): Fix typo so the for loop
actually checks each value in m_entries.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebBackForwardList.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-02-01  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r222824): UI process crashes in WebKit::WebBackForwardList::backItem const
+        <https://webkit.org/b/182409>
+        <rdar://problem/35495094>
+
+        Reviewed by Alex Christensen.
+
+        * UIProcess/WebBackForwardList.cpp:
+        (WebKit::WebBackForwardList::goToItem): Fix typo so the for loop
+        actually checks each value in m_entries.
+
 2018-02-01  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/UIProcess/WebBackForwardList.cpp

@@ -200 +200 @@
         targetIndex = notFound;
         for (size_t i = 0; i < m_entries.size(); ++i) {
-            if (m_entries[0].ptr() == &item) {
+            if (m_entries[i].ptr() == &item) {
                 targetIndex = i;
                 break;