Changeset 228018 in webkit


Ignore:
Timestamp:
Feb 2, 2018 11:07:31 AM (6 years ago)
Author:
sbarati@apple.com
Message:

MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope
​https://bugs.webkit.org/show_bug.cgi?id=182402

Reviewed by Yusuke Suzuki.

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r228012 r228018  
     12018-02-02  Saam Barati  <sbarati@apple.com>
     2
     3        MapHash should return true to doesGC in the DFG depending on useKind because it might resolve a rope
     4        https://bugs.webkit.org/show_bug.cgi?id=182402
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * dfg/DFGDoesGC.cpp:
     9        (JSC::DFG::doesGC):
     10
    1112018-02-02  Yusuke Suzuki  <utatane.tea@gmail.com>
    212

  • trunk/Source/JavaScriptCore/dfg/DFGDoesGC.cpp

    r227723 r228018  
    206206    case CheckTraps:
    207207    case StringFromCharCode:
    208     case MapHash:
    209208    case NormalizeMapKey:
    210209    case GetMapBucket:
    … …  
    356355    case MapSet:
    357356        return true;
     357
     358    case MapHash:
     359        switch (node->child1().useKind()) {
     360        case BooleanUse:
     361        case Int32Use:
     362        case SymbolUse:
     363        case ObjectUse:
     364            return false;
     365        default:
     366            // We might resolve a rope.
     367            return true;
     368        }
    358369       
    359370    case MultiPutByOffset:
Note: See TracChangeset for help on using the changeset viewer.