Changeset 228249 in webkit

Timestamp:

Feb 7, 2018 4:11:54 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

Remove unused CSSParserContext in CSSParser::parseInlineStyleDeclaration
​https://bugs.webkit.org/show_bug.cgi?id=182587

Reviewed by Simon Fraser.

Removed the code. There is no need to create an unused CSSParserContext in CSSParser.

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseInlineStyleDeclaration):

• css/parser/CSSParser.h:
• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parseInlineStyleDeclaration):

• css/parser/CSSParserImpl.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/parser/CSSParser.cpp (modified) (1 diff)
• css/parser/CSSParser.h (modified) (1 diff)
• css/parser/CSSParserImpl.cpp (modified) (1 diff)
• css/parser/CSSParserImpl.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-07  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove unused CSSParserContext in CSSParser::parseInlineStyleDeclaration
+        https://bugs.webkit.org/show_bug.cgi?id=182587
+
+        Reviewed by Simon Fraser.
+
+        Removed the code. There is no need to create an unused CSSParserContext in CSSParser.
+
+        * css/parser/CSSParser.cpp:
+        (WebCore::CSSParser::parseInlineStyleDeclaration):
+        * css/parser/CSSParser.h:
+        * css/parser/CSSParserImpl.cpp:
+        (WebCore::CSSParserImpl::parseInlineStyleDeclaration):
+        * css/parser/CSSParserImpl.h:
+
 2018-02-07  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebCore/css/parser/CSSParser.cpp

@@ -223 +223 @@
 }
 
-Ref<ImmutableStyleProperties> CSSParser::parseInlineStyleDeclaration(const String& string, Element* element)
-{
-    CSSParserContext context(element->document());
-    context.mode = strictToCSSParserMode(element->isHTMLElement() && !element->document().inQuirksMode());
+Ref<ImmutableStyleProperties> CSSParser::parseInlineStyleDeclaration(const String& string, const Element* element)
+{
     return CSSParserImpl::parseInlineStyleDeclaration(string, element);
 }

trunk/Source/WebCore/css/parser/CSSParser.h

@@ -72 +72 @@
 
     WEBCORE_EXPORT bool parseDeclaration(MutableStyleProperties&, const String&);
-    static Ref<ImmutableStyleProperties> parseInlineStyleDeclaration(const String&, Element*);
+    static Ref<ImmutableStyleProperties> parseInlineStyleDeclaration(const String&, const Element*);
 
     void parseSelector(const String&, CSSSelectorList&);

trunk/Source/WebCore/css/parser/CSSParserImpl.cpp

@@ -156 +156 @@
 }
 
-Ref<ImmutableStyleProperties> CSSParserImpl::parseInlineStyleDeclaration(const String& string, Element* element)
+Ref<ImmutableStyleProperties> CSSParserImpl::parseInlineStyleDeclaration(const String& string, const Element* element)
 {
     CSSParserContext context(element->document());

trunk/Source/WebCore/css/parser/CSSParserImpl.h

@@ -86 +86 @@
     static CSSParser::ParseResult parseValue(MutableStyleProperties*, CSSPropertyID, const String&, bool important, const CSSParserContext&);
     static CSSParser::ParseResult parseCustomPropertyValue(MutableStyleProperties*, const AtomicString& propertyName, const String&, bool important, const CSSParserContext&);
-    static Ref<ImmutableStyleProperties> parseInlineStyleDeclaration(const String&, Element*);
+    static Ref<ImmutableStyleProperties> parseInlineStyleDeclaration(const String&, const Element*);
     static bool parseDeclarationList(MutableStyleProperties*, const String&, const CSSParserContext&);
     static RefPtr<StyleRuleBase> parseRule(const String&, const CSSParserContext&, StyleSheetContents*, AllowedRulesType);