Changeset 228281 in webkit

Timestamp:

Feb 8, 2018 10:38:29 AM (6 years ago)

Author:

Philippe Normand

Message:

[GStreamer] WebKit improperly handles missing GStreamer elements
​https://bugs.webkit.org/show_bug.cgi?id=171205

Reviewed by Michael Catanzaro.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Add a
test checking the videoflip element was correctly created. It
might not be available on some exotic distros such as Gentoo.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-08  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] WebKit improperly handles missing GStreamer elements
+        https://bugs.webkit.org/show_bug.cgi?id=171205
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): Add a
+        test checking the videoflip element was correctly created. It
+        might not be available on some exotic distros such as Gentoo.
+
 2018-02-08  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -2186 +2186 @@
         // the image-orientation tag.
         GstElement* videoFlip = gst_element_factory_make("videoflip", nullptr);
-        g_object_set(videoFlip, "method", 8, nullptr);
-        g_object_set(m_pipeline.get(), "video-filter", videoFlip, nullptr);
+        if (videoFlip) {
+            g_object_set(videoFlip, "method", 8, nullptr);
+            g_object_set(m_pipeline.get(), "video-filter", videoFlip, nullptr);
+        } else
+            GST_WARNING("The videoflip element is missing, video rotation support is now disabled. Please check your gst-plugins-good installation.");
     }