Changeset 228368 in webkit

Timestamp:

Feb 11, 2018 12:09:57 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Scrolling sometimes jumps around
​https://bugs.webkit.org/show_bug.cgi?id=178519

Patch by Gustavo Noronha Silva <​gustavo.noronha@collabora.co.uk> on 2018-02-11
Reviewed by Michael Catanzaro.

• platform/gtk/ScrollAnimatorGtk.cpp:

(WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
returned, causing the viewport to scroll to the end of the page.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/ScrollAnimatorGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
+
+        [GTK] Scrolling sometimes jumps around
+        https://bugs.webkit.org/show_bug.cgi?id=178519
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/gtk/ScrollAnimatorGtk.cpp:
+        (WebCore::ScrollAnimatorGtk::computeVelocity): use -1 as the multiplier for the accumulated deltas,
+        since all we need is to make them negative. Multiplying by -1000 leads to very high velocities being
+        returned, causing the viewport to scroll to the end of the page.
+
 2018-02-10  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp

@@ -123 +123 @@
     m_scrollHistory.clear();
 
-    return FloatPoint(accumDelta.x() * -1000 / (last - first).value(), accumDelta.y() * -1000 / (last - first).value());
+    return FloatPoint(accumDelta.x() * -1 / (last - first).value(), accumDelta.y() * -1 / (last - first).value());
 }