Changeset 228388 in webkit


Ignore:
Timestamp:
Feb 12, 2018 12:28:02 PM (6 years ago)
Author:
mark.lam@apple.com
Message:

Fix missing exception check in RegExpObject::matchGlobal().
https://bugs.webkit.org/show_bug.cgi?id=182701
<rdar://problem/37465865>

Reviewed by Michael Saboff.

This issue was discovered when running JSC tests on an asm LLInt build with
JSC_useJIT=false.

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::matchGlobal):

Location:
trunk/Source/JavaScriptCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r228370 r228388  
     12018-02-12  Mark Lam  <mark.lam@apple.com>
     2
     3        Fix missing exception check in RegExpObject::matchGlobal().
     4        https://bugs.webkit.org/show_bug.cgi?id=182701
     5        <rdar://problem/37465865>
     6
     7        Reviewed by Michael Saboff.
     8
     9        This issue was discovered when running JSC tests on an asm LLInt build with
     10        JSC_useJIT=false.
     11
     12        * runtime/RegExpObject.cpp:
     13        (JSC::RegExpObject::matchGlobal):
     14
    1152018-02-11  Guillaume Emont  <guijemont@igalia.com>
    216
  • trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp

    r223645 r228388  
    11/*
    22 *  Copyright (C) 1999-2000 Harri Porten (porten@kde.org)
    3  *  Copyright (C) 2003-2017 Apple Inc. All Rights Reserved.
     3 *  Copyright (C) 2003-2018 Apple Inc. All Rights Reserved.
    44 *
    55 *  This library is free software; you can redistribute it and/or
     
    259259
    260260    String s = string->value(exec);
     261    RETURN_IF_EXCEPTION(scope, { });
    261262    RegExpConstructor* regExpConstructor = globalObject->regExpConstructor();
    262    
     263
     264    ASSERT(!s.isNull());
    263265    if (regExp->unicode()) {
    264266        unsigned stringLength = s.length();
Note: See TracChangeset for help on using the changeset viewer.