Changeset 228401 in webkit
- Timestamp:
- Feb 12, 2018 3:41:17 PM (6 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/JSTests/ChangeLog
r228366 r228401 1 2018-02-12 Saam Barati <sbarati@apple.com> 2 3 DFG::emitCodeToGetArgumentsArrayLength needs to handle NewArrayBuffer/PhantomNewArrayBuffer 4 https://bugs.webkit.org/show_bug.cgi?id=182706 5 <rdar://problem/36833681> 6 7 Reviewed by Filip Pizlo. 8 9 * stress/get-array-length-phantom-new-array-buffer.js: Added. 10 (effects): 11 (foo): 12 1 13 2018-02-09 Filip Pizlo <fpizlo@apple.com> 2 14 -
trunk/Source/JavaScriptCore/ChangeLog
r228397 r228401 1 2018-02-12 Saam Barati <sbarati@apple.com> 2 3 DFG::emitCodeToGetArgumentsArrayLength needs to handle NewArrayBuffer/PhantomNewArrayBuffer 4 https://bugs.webkit.org/show_bug.cgi?id=182706 5 <rdar://problem/36833681> 6 7 Reviewed by Filip Pizlo. 8 9 When we added support for PhantomNewArrayBuffer, we forgot to update 10 the emitCodeToGetArgumentsArrayLength function to handle PhantomNewArrayBuffer. 11 This patch adds that support. It's trivial to generate the length for 12 a PhantomNewArrayBuffer node since it's a constant buffer, with a constant 13 length. 14 15 * dfg/DFGArgumentsUtilities.cpp: 16 (JSC::DFG::emitCodeToGetArgumentsArrayLength): 17 1 18 2018-02-12 Mark Lam <mark.lam@apple.com> 2 19 -
trunk/Source/JavaScriptCore/dfg/DFGArgumentsUtilities.cpp
r228035 r228401 66 66 graph, arguments, 67 67 arguments->op() == CreateDirectArguments || arguments->op() == CreateScopedArguments 68 || arguments->op() == CreateClonedArguments || arguments->op() == CreateRest 69 || arguments->op() == PhantomDirectArguments || arguments->op() == PhantomClonedArguments || arguments->op() == PhantomCreateRest, 68 || arguments->op() == CreateClonedArguments || arguments->op() == CreateRest || arguments->op() == NewArrayBuffer 69 || arguments->op() == PhantomDirectArguments || arguments->op() == PhantomClonedArguments 70 || arguments->op() == PhantomCreateRest || arguments->op() == PhantomNewArrayBuffer, 70 71 arguments->op()); 72 73 if (arguments->op() == NewArrayBuffer || arguments->op() == PhantomNewArrayBuffer) { 74 return insertionSet.insertConstant( 75 nodeIndex, origin, jsNumber(arguments->castOperand<JSFixedArray*>()->length())); 76 } 71 77 72 78 InlineCallFrame* inlineCallFrame = arguments->origin.semantic.inlineCallFrame;
Note: See TracChangeset
for help on using the changeset viewer.