Changeset 228426 in webkit

Timestamp:

Feb 13, 2018 11:08:51 AM (6 years ago)

Author:

jmarcell@apple.com

Message:

Apply patch. rdar://problem/37485750

CoreAudioCaptureSourceIOSListener should be a WebProcess singleton

Location:

tags/Safari-605.1.27.1/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.cpp (modified) (1 diff)

tags/Safari-605.1.27.1/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-12  Jason Marcell  <jmarcell@apple.com>
+
+        Apply patch. rdar://problem/37485750
+
+    CoreAudioCaptureSourceIOSListener should be a WebProcess singleton
+
+    2018-02-12  Youenn Fablet  <youenn@apple.com>
+
+            CoreAudioCaptureSourceIOSListener should be a WebProcess singleton
+            https://bugs.webkit.org/show_bug.cgi?id=182606
+            <rdar://problem/37470882>
+
+            Reviewed by Eric Carlson.
+
+            Covered by manual testing.
+            In case shared unit is suspended, unsuspend it when creating a new audio source.
+            This creation should only happen when WebKit iOS is foregrounded.
+
+            * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+            (WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
+
 2018-02-08  Jason Marcell  <jmarcell@apple.com>
 

tags/Safari-605.1.27.1/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp

@@ -725 +725 @@
 
     unit.addClient(*this);
+
+#if PLATFORM(IOS)
+    // We ensure that we unsuspend ourselves on the constructor as a capture source
+    // is created when getUserMedia grants access which only happens when the process is foregrounded.
+    if (unit.isSuspended())
+        unit.reconfigureAudioUnit();
+#endif
 }