Changeset 228478 in webkit

Timestamp:

Feb 14, 2018 11:47:57 AM (6 years ago)

Author:

wilander@apple.com

Message:

Make maximumParallelReadCount static to fix lambda capture error in WebKit::NetworkCache::Storage::traverse()
​https://bugs.webkit.org/show_bug.cgi?id=182797
<rdar://problem/37540594>

Reviewed by Tim Horton.

This capture was added in r228455 and causes a build failure when
run with -Wunused-lambda-capture. Xcode also warns about it.

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::traverse):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cache/NetworkCacheStorage.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-02-14  John Wilander  <wilander@apple.com>
+
+        Make maximumParallelReadCount static to fix lambda capture error in WebKit::NetworkCache::Storage::traverse()
+        https://bugs.webkit.org/show_bug.cgi?id=182797
+        <rdar://problem/37540594>
+
+        Reviewed by Tim Horton.
+
+        This capture was added in r228455 and causes a build failure when
+        run with -Wunused-lambda-capture. Xcode also warns about it.
+
+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
+        (WebKit::NetworkCache::Storage::traverse):
+
 2018-02-14  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp

@@ -908 +908 @@
             });
 
-            const unsigned maximumParallelReadCount = 5;
-            traverseOperation.activeCondition.wait(lock, [&traverseOperation, maximumParallelReadCount] {
+            static const unsigned maximumParallelReadCount = 5;
+            traverseOperation.activeCondition.wait(lock, [&traverseOperation] {
                 return traverseOperation.activeCount <= maximumParallelReadCount;
             });