Changeset 228501 in webkit

Timestamp:

Feb 14, 2018 6:52:50 PM (6 years ago)

Author:

cturner@igalia.com

Message:

Get Garden-O-Matic running again.
​https://bugs.webkit.org/show_bug.cgi?id=179089

Reviewed by Carlos Alberto Lopez Perez.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:

(parseCommitData): Author field is not always spelled 'author' these days.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

No longer have a 32-bit builder.

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:

(ui.perf.View.base.init): createElement has a required parameter these days.

• Scripts/webkitpy/tool/commands/gardenomatic.py:

(GardenOMatic): Override use_globs so that platform lookup in config.js works.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js (modified) (1 diff)
• BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/gardenomatic.py (modified) (2 diffs)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js

@@ -91 +91 @@
     var commits = Array.prototype.map.call(responseXML.getElementsByTagName('item'), function(item) {
         var title = item.getElementsByTagName('title')[0].textContent;
-        var author = item.getElementsByTagName('author')[0].textContent;
+        var author = item.getElementsByTagName('author')[0] || item.getElementsByTagName('dc:creator')[0];
+        author = author.textContent;
         var time = item.getElementsByTagName('pubDate')[0].textContent;
 

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js

@@ -67 +67 @@
         waterfallURL: 'https://build.webkit.org/waterfall',
         builders: {
-            'GTK Linux 32-bit Release' : {version: '32-bit release'},
             'GTK Linux 64-bit Release (Tests)' : {version: '64-bit release'},
             'GTK Linux 64-bit Debug (Tests)' : {version: '64-bit debug', debug: true},

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js

@@ -53 +53 @@
 
         var stream = new ui.notifications.Stream();
-        var notifications = document.createElement()
+        var notifications = document.createElement('div');
         this._notification = ui.notifications.Info("Loading list of perf dashboards...");
         stream.appendChild(this._notification);

trunk/Tools/ChangeLog

@@ +1 @@
+2018-02-14  Charlie Turner  <cturner@igalia.com>
+
+        Get Garden-O-Matic running again.
+        https://bugs.webkit.org/show_bug.cgi?id=179089
+
+        Reviewed by Carlos Alberto Lopez Perez.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
+        (parseCommitData): Author field is not always spelled 'author' these days.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
+        No longer have a 32-bit builder.
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
+        (ui.perf.View.base.init): createElement has a required parameter these days.
+        * Scripts/webkitpy/tool/commands/gardenomatic.py:
+        (GardenOMatic): Override use_globs so that platform lookup in config.js works.
+
 2018-02-14  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py

@@ -26 +26 @@
 from webkitpy.tool.commands.rebaseline import AbstractRebaseliningCommand
 from webkitpy.tool.servers.gardeningserver import GardeningHTTPServer
+from webkitpy.port import factory
 
 
@@ -31 +32 @@
     name = "garden-o-matic"
     help_text = "Command for gardening the WebKit tree."
+
+    # REVIEW: Reset the option here because globbing isn't useful for us, but apparently
+    # it's useful for other rebaselining commands because use_globs=True is set in parent.
+    platform_options = factory.platform_options()
 
     def __init__(self):