Changeset 228560 in webkit


Ignore:
Timestamp:
Feb 16, 2018 9:41:12 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

IndexedDB: Several test crash in when destroying a IDBKeyData
​https://bugs.webkit.org/show_bug.cgi?id=167576

Patch by Fujii Hironori <Fujii Hironori> on 2018-02-16
Reviewed by Michael Catanzaro.

Source/WebCore:

IDBKeyDataHashTraits::constructDeletedValue is using operator= to
assign deletedValue. But, the value is destructed just before
calling constructDeletedValue. You can't use operator= for a
destructed value.

No new tests (Covered by existing tests).

  • Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyDataHashTraits::constructDeletedValue):
Construct null value before assigning deletedValue.

LayoutTests:

  • platform/gtk/TestExpectations: Unmarked

imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html,
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html
and storage/indexeddb/modern/index-3-private.html.

  • platform/wpe/TestExpectations: Unmarked

imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html and
imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html.

Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r228558 r228560  
     12018-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        IndexedDB: Several test crash in when destroying a IDBKeyData
     4        https://bugs.webkit.org/show_bug.cgi?id=167576
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        * platform/gtk/TestExpectations: Unmarked
     9        imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html,
     10        imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html
     11        and storage/indexeddb/modern/index-3-private.html.
     12        * platform/wpe/TestExpectations: Unmarked
     13        imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html and
     14        imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html.
     15
    1162018-02-16  Claudio Saavedra  <csaavedra@igalia.com>
    217

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r228554 r228560  
    12961296webkit.org/b/163782 media/video-played-ranges-1.html [ Crash Pass ]
    12971297
    1298 webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html [ Crash Timeout ]
    1299 webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html [ Crash Timeout ]
    1300 webkit.org/b/167576 storage/indexeddb/modern/index-3-private.html [ Crash ]
    1301 
    13021298webkit.org/b/169811 fast/mediastream/captureStream/canvas2d.html [ Crash Timeout ]
    13031299webkit.org/b/169811 fast/mediastream/captureStream/canvas3d.html [ Crash Timeout ]

  • trunk/LayoutTests/platform/wpe/TestExpectations

    r228558 r228560  
    417417# Flaky
    418418webkit.org/b/177530 imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm [ Pass Failure ]
    419 
    420 
    421 webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating.html [ Crash ]
    422 webkit.org/b/167576 imported/w3c/IndexedDB-private-browsing/idbcursor_iterating_index.html [ Crash ]
    423419
    424420webkit.org/b/174354 imported/w3c/IndexedDB-private-browsing/idbfactory_open.html [ Crash Pass ]

  • trunk/Source/WebCore/ChangeLog

    r228559 r228560  
     12018-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        IndexedDB: Several test crash in when destroying a IDBKeyData
     4        https://bugs.webkit.org/show_bug.cgi?id=167576
     5
     6        Reviewed by Michael Catanzaro.
     7
     8        IDBKeyDataHashTraits::constructDeletedValue is using operator= to
     9        assign deletedValue. But, the value is destructed just before
     10        calling constructDeletedValue. You can't use operator= for a
     11        destructed value.
     12
     13        No new tests (Covered by existing tests).
     14
     15        * Modules/indexeddb/IDBKeyData.h:
     16        (WebCore::IDBKeyDataHashTraits::constructDeletedValue):
     17        Construct null value before assigning deletedValue.
     18
    1192018-02-16  Zalan Bujtas  <zalan@apple.com>
    220

  • trunk/Source/WebCore/Modules/indexeddb/IDBKeyData.h

    r222233 r228560  
    209209    static void constructDeletedValue(IDBKeyData& key)
    210210    {
     211        new (&key) IDBKeyData;
    211212        key = IDBKeyData::deletedValue();
    212213    }
Note: See TracChangeset for help on using the changeset viewer.