Changeset 228927 in webkit

Timestamp:

Feb 22, 2018 11:41:18 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[Curl] Fix warning on clang.
​https://bugs.webkit.org/show_bug.cgi?id=182986

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-02-22
Reviewed by Konstantin Tokarev.

No new tests because there's no behaviro changes.

• platform/network/curl/CurlResourceHandleDelegate.cpp:

(WebCore::CurlResourceHandleDelegate::curlDidSendData):
(WebCore::CurlResourceHandleDelegate::curlDidReceiveBuffer):
(WebCore::CurlResourceHandleDelegate::curlDidFailWithError):

• platform/network/curl/CurlResourceHandleDelegate.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/curl/CurlResourceHandleDelegate.cpp (modified) (3 diffs)
• platform/network/curl/CurlResourceHandleDelegate.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-22  Basuke Suzuki  <Basuke.Suzuki@sony.com>
+
+        [Curl] Fix warning on clang.
+        https://bugs.webkit.org/show_bug.cgi?id=182986
+
+        Reviewed by Konstantin Tokarev.
+
+        No new tests because there's no behaviro changes.
+
+        * platform/network/curl/CurlResourceHandleDelegate.cpp:
+        (WebCore::CurlResourceHandleDelegate::curlDidSendData):
+        (WebCore::CurlResourceHandleDelegate::curlDidReceiveBuffer):
+        (WebCore::CurlResourceHandleDelegate::curlDidFailWithError):
+        * platform/network/curl/CurlResourceHandleDelegate.h:
+
 2018-02-22  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.cpp

@@ -77 +77 @@
 void CurlResourceHandleDelegate::curlDidSendData(CurlRequest& request, unsigned long long bytesSent, unsigned long long totalBytesToBeSent)
 {
+    UNUSED_PARAM(request);
     ASSERT(isMainThread());
 
@@ -145 +146 @@
 void CurlResourceHandleDelegate::curlDidReceiveBuffer(CurlRequest& request, Ref<SharedBuffer>&& buffer)
 {
+    UNUSED_PARAM(request);
     ASSERT(isMainThread());
 
@@ -169 +171 @@
 void CurlResourceHandleDelegate::curlDidFailWithError(CurlRequest& request, const ResourceError& resourceError)
 {
+    UNUSED_PARAM(request);
     ASSERT(isMainThread());
 

trunk/Source/WebCore/platform/network/curl/CurlResourceHandleDelegate.h

@@ -40 +40 @@
 class ResourceHandleInternal;
 
-class CurlResourceHandleDelegate : public CurlRequestClient {
+class CurlResourceHandleDelegate final : public CurlRequestClient {
     WTF_MAKE_NONCOPYABLE(CurlResourceHandleDelegate); WTF_MAKE_FAST_ALLOCATED;
 public:
@@ -49 +49 @@
     // CurlRequestClient methods
 
-    void ref();
-    void deref();
+    void ref() final;
+    void deref() final;
 
-    void curlDidSendData(CurlRequest&, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;
-    void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) override;
-    void curlDidReceiveBuffer(CurlRequest&, Ref<SharedBuffer>&&) override;
-    void curlDidComplete(CurlRequest&) override;
-    void curlDidFailWithError(CurlRequest&, const ResourceError&) override;
+    void curlDidSendData(CurlRequest&, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) final;
+    void curlDidReceiveResponse(CurlRequest&, const CurlResponse&) final;
+    void curlDidReceiveBuffer(CurlRequest&, Ref<SharedBuffer>&&) final;
+    void curlDidComplete(CurlRequest&) final;
+    void curlDidFailWithError(CurlRequest&, const ResourceError&) final;
 
 private: