Changeset 228934 in webkit

Timestamp:

Feb 22, 2018 2:36:47 PM (6 years ago)

Author:

Chris Dumez

Message:

ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
​https://bugs.webkit.org/show_bug.cgi?id=183059
<rdar://problem/37800202>

Reviewed by Youenn Fablet.

Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
given that it is a String and it would not be safe to send it to another thread otherwise.

• platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::setAsIsolatedCopy):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/ResourceRequestBase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-02-22  Chris Dumez  <cdumez@apple.com>
+
+        ResourceRequestBase::isolatedCopy() fails to isolate copy the cachePartition
+        https://bugs.webkit.org/show_bug.cgi?id=183059
+        <rdar://problem/37800202>
+
+        Reviewed by Youenn Fablet.
+
+        Update ResourceRequestBase::setAsIsolatedCopy() to call isolatedCopy() on the cachePartition as well,
+        given that it is a String and it would not be safe to send it to another thread otherwise.
+
+        * platform/network/ResourceRequestBase.cpp:
+        (WebCore::ResourceRequestBase::setAsIsolatedCopy):
+
 2018-02-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/network/ResourceRequestBase.cpp

@@ -65 +65 @@
     setRequester(other.requester());
     setInitiatorIdentifier(other.initiatorIdentifier().isolatedCopy());
-    setCachePartition(other.cachePartition());
+    setCachePartition(other.cachePartition().isolatedCopy());
 
     updateResourceRequest();