Changeset 229188 in webkit


Ignore:
Timestamp:
Mar 2, 2018 2:10:17 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

LayoutTest imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=179248
<rdar://problem/35377756>

Patch by Youenn Fablet <youenn@apple.com> on 2018-03-02
Reviewed by Chris Dumez.

In case we go up to the initializeSize step and Caches was cleared
between the time we stated to initialize and the time we got there,
we need to make as if Caches was not initialized,
thus keeping m_isInitialized to false and m_storage to nullptr.

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::initializeSize):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r229183 r229188  
     12018-03-02  Youenn Fablet  <youenn@apple.com>
     2
     3        LayoutTest imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html is a flaky failure
     4        https://bugs.webkit.org/show_bug.cgi?id=179248
     5        <rdar://problem/35377756>
     6
     7        Reviewed by Chris Dumez.
     8
     9        In case we go up to the initializeSize step and Caches was cleared
     10        between the time we stated to initialize and the time we got there,
     11        we need to make as if Caches was not initialized,
     12        thus keeping m_isInitialized to false and m_storage to nullptr.
     13
     14        * NetworkProcess/cache/CacheStorageEngineCaches.cpp:
     15        (WebKit::CacheStorage::Caches::initializeSize):
     16
    1172018-03-02  Youenn Fablet  <youenn@apple.com>
    218
  • trunk/Source/WebKit/NetworkProcess/cache/CacheStorageEngineCaches.cpp

    r229151 r229188  
    190190    m_storage->traverse({ }, 0, [protectedThis = makeRef(*this), this, protectedStorage = makeRef(*m_storage), size](const auto* storage, const auto& information) mutable {
    191191        if (!storage) {
     192            if (m_pendingInitializationCallbacks.isEmpty()) {
     193                // Caches was cleared so let's not get initialized.
     194                m_storage = nullptr;
     195                return;
     196            }
    192197            m_size = size;
    193198            m_isInitialized = true;
Note: See TracChangeset for help on using the changeset viewer.