Changeset 229319 in webkit

Timestamp:

Mar 6, 2018 4:17:36 AM (6 years ago)

Author:

zandobersek@gmail.com

Message:

Unreviewed. Addressing further review feedback for patch landed in r229315.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::commitSceneState): There's no need for
explicit calls of the clear() method on both containers in the CommitScope
objects, the destructors invoked for these objects from the CommitScope
destructor will have the same effect.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-06  Zan Dobersek  <zdobersek@igalia.com>
+
+        Unreviewed. Addressing further review feedback for patch landed in r229315.
+
+        * Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
+        (WebKit::CoordinatedGraphicsScene::commitSceneState): There's no need for
+        explicit calls of the clear() method on both containers in the CommitScope
+        objects, the destructors invoked for these objects from the CommitScope
+        destructor will have the same effect.
+
 2018-03-06  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp

@@ -541 +541 @@
     for (auto& backingStore : commitScope.backingStoresWithPendingBuffers)
         backingStore->commitTileOperations(*m_textureMapper);
-
-    commitScope.releasedImageBackings.clear();
-    commitScope.backingStoresWithPendingBuffers.clear();
 }