Changeset 229338 in webkit

Timestamp:

Mar 6, 2018 12:53:52 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r229330.
​https://bugs.webkit.org/show_bug.cgi?id=183379

Broke some Apple internal code (Requested by ap on #webkit).

Reverted changeset:

"Remove unused crash hook functionality"
​https://bugs.webkit.org/show_bug.cgi?id=183369
​https://trac.webkit.org/changeset/229330

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Assertions.cpp (modified) (2 diffs)
• wtf/Assertions.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2018-03-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r229330.
+        https://bugs.webkit.org/show_bug.cgi?id=183379
+
+        Broke some Apple internal code (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "Remove unused crash hook functionality"
+        https://bugs.webkit.org/show_bug.cgi?id=183369
+        https://trac.webkit.org/changeset/229330
+
 2018-03-06  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WTF/wtf/Assertions.cpp

@@ -252 +252 @@
 }
 
+static WTFCrashHookFunction globalHook = 0;
+
+void WTFSetCrashHook(WTFCrashHookFunction function)
+{
+    globalHook = function;
+}
+
 #if !defined(NDEBUG) || !OS(DARWIN)
 void WTFCrash()
 {
+    if (globalHook)
+        globalHook();
+
     WTFReportBacktrace();
 #if ASAN_ENABLED
@@ -281 +291 @@
 {
     CRASH();
+}
+
+#if HAVE(SIGNAL_H)
+static NO_RETURN void dumpBacktraceSignalHandler(int sig)
+{
+    WTFReportBacktrace();
+    exit(128 + sig);
+}
+
+static void installSignalHandlersForFatalErrors(void (*handler)(int))
+{
+    signal(SIGILL, handler); //    4: illegal instruction (not reset when caught).
+    signal(SIGTRAP, handler); //   5: trace trap (not reset when caught).
+    signal(SIGFPE, handler); //    8: floating point exception.
+    signal(SIGBUS, handler); //   10: bus error.
+    signal(SIGSEGV, handler); //  11: segmentation violation.
+    signal(SIGSYS, handler); //   12: bad argument to system call.
+    signal(SIGPIPE, handler); //  13: write on a pipe with no reader.
+    signal(SIGXCPU, handler); //  24: exceeded CPU time limit.
+    signal(SIGXFSZ, handler); //  25: exceeded file size limit.
+}
+
+static void resetSignalHandlersForFatalErrors()
+{
+    installSignalHandlersForFatalErrors(SIG_DFL);
+}
+#endif
+
+void WTFInstallReportBacktraceOnCrashHook()
+{
+#if HAVE(SIGNAL_H)
+    // Needed otherwise we are going to dump the stack trace twice
+    // in case we hit an assertion.
+    WTFSetCrashHook(&resetSignalHandlersForFatalErrors);
+    installSignalHandlersForFatalErrors(&dumpBacktraceSignalHandler);
+#endif
 }
 

trunk/Source/WTF/wtf/Assertions.h

@@ -201 +201 @@
 WTF_EXPORT_PRIVATE void WTFPrintBacktrace(void** stack, int size);
 
+typedef void (*WTFCrashHookFunction)(void);
+WTF_EXPORT_PRIVATE void WTFSetCrashHook(WTFCrashHookFunction);
+WTF_EXPORT_PRIVATE void WTFInstallReportBacktraceOnCrashHook(void);
+
 WTF_EXPORT_PRIVATE bool WTFIsDebuggerAttached(void);