Changeset 229340 in webkit


Ignore:
Timestamp:
Mar 6, 2018 1:27:03 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

[Web Animations] Add a new CSSTransition subclass of WebAnimation
​https://bugs.webkit.org/show_bug.cgi?id=183373
<rdar://problem/38181985>

Patch by Antoine Quint <Antoine Quint> on 2018-03-06
Reviewed by Dean Jackson.

Adding a new CSSAnimation subclass which we will create in a later patch while resolving styles
upon identifying that a new CSS Animation has been added to an element.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/CSSTransition.cpp: Added.

(WebCore::CSSTransition::create):
(WebCore::CSSTransition::CSSTransition):

  • animation/CSSTransition.h: Added.
  • animation/CSSTransition.idl: Added.
  • animation/KeyframeEffect.cpp:
  • animation/WebAnimation.h:

(WebCore::WebAnimation::isCSSTransition const):

  • bindings/js/JSWebAnimationCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/WebCoreBuiltinNames.h:
Location:
trunk/Source/WebCore
Files:
3 added
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/CMakeLists.txt

    r229327 r229340  
    451451    animation/AnimationTimeline.idl
    452452    animation/CSSAnimation.idl
     453    animation/CSSTransition.idl
    453454    animation/CompositeOperation.idl
    454455    animation/ComputedTimingProperties.idl

  • trunk/Source/WebCore/ChangeLog

    r229336 r229340  
     12018-03-06  Antoine Quint  <graouts@apple.com>
     2
     3        [Web Animations] Add a new CSSTransition subclass of WebAnimation
     4        https://bugs.webkit.org/show_bug.cgi?id=183373
     5        <rdar://problem/38181985>
     6
     7        Reviewed by Dean Jackson.
     8
     9        Adding a new CSSAnimation subclass which we will create in a later patch while resolving styles
     10        upon identifying that a new CSS Animation has been added to an element.
     11
     12        * CMakeLists.txt:
     13        * DerivedSources.make:
     14        * Sources.txt:
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * animation/CSSTransition.cpp: Added.
     17        (WebCore::CSSTransition::create):
     18        (WebCore::CSSTransition::CSSTransition):
     19        * animation/CSSTransition.h: Added.
     20        * animation/CSSTransition.idl: Added.
     21        * animation/KeyframeEffect.cpp:
     22        * animation/WebAnimation.h:
     23        (WebCore::WebAnimation::isCSSTransition const):
     24        * bindings/js/JSWebAnimationCustom.cpp:
     25        (WebCore::toJSNewlyCreated):
     26        * bindings/js/WebCoreBuiltinNames.h:
     27
    1282018-03-06  Megan Gardner  <megan_gardner@apple.com>
    229

  • trunk/Source/WebCore/DerivedSources.make

    r229327 r229340  
    373373    $(WebCore)/animation/ComputedTimingProperties.idl \
    374374    $(WebCore)/animation/CSSAnimation.idl \
     375    $(WebCore)/animation/CSSTransition.idl \
    375376    $(WebCore)/animation/DocumentTimeline.idl \
    376377    $(WebCore)/animation/FillMode.idl \

  • trunk/Source/WebCore/Sources.txt

    r229327 r229340  
    338338animation/AnimationTimeline.cpp
    339339animation/CSSAnimation.cpp
     340animation/CSSTransition.cpp
    340341animation/DocumentTimeline.cpp
    341342animation/KeyframeEffect.cpp
    … …  
    24392440JSCryptoRsaKeyAlgorithm.cpp
    24402441JSCSSAnimation.cpp
     2442JSCSSTransition.cpp
    24412443JSCustomElementRegistry.cpp
    24422444JSCustomEvent.cpp

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r229336 r229340  
    88308830                712157C01DCCCA0700AA7A92 /* macos-fullscreen-media-controls.css */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.css; path = "macos-fullscreen-media-controls.css"; sourceTree = "<group>"; };
    88318831                712157C11DCCCA0700AA7A92 /* macos-fullscreen-media-controls.js */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.javascript; path = "macos-fullscreen-media-controls.js"; sourceTree = "<group>"; };
     8832                7123C1822047399200789392 /* JSCSSTransition.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSCSSTransition.cpp; sourceTree = "<group>"; };
     8833                7123C1842047399300789392 /* JSCSSTransition.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSCSSTransition.h; sourceTree = "<group>"; };
     8834                7123C185204739B900789392 /* CSSTransition.idl */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = CSSTransition.idl; sourceTree = "<group>"; };
     8835                7123C186204739BA00789392 /* CSSTransition.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CSSTransition.h; sourceTree = "<group>"; };
     8836                7123C187204739BB00789392 /* CSSTransition.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CSSTransition.cpp; sourceTree = "<group>"; };
    88328837                71247E261FEA5F60008C08CE /* JSKeyframeAnimationOptions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSKeyframeAnimationOptions.h; sourceTree = "<group>"; };
    88338838                71247E281FEA5F61008C08CE /* JSIterationCompositeOperation.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSIterationCompositeOperation.cpp; sourceTree = "<group>"; };
    … …  
    1554015545                                71B28424203CEC0B0036AA5D /* JSCSSAnimation.cpp */,
    1554115546                                71B28426203CEC0D0036AA5D /* JSCSSAnimation.h */,
     15547                                7123C1822047399200789392 /* JSCSSTransition.cpp */,
     15548                                7123C1842047399300789392 /* JSCSSTransition.h */,
    1554215549                                71025EDB1F99F1A8004A250C /* JSDocumentTimeline.cpp */,
    1554315550                                71025EDC1F99F1A8004A250C /* JSDocumentTimeline.h */,
    … …  
    1921619223                                71C29E31203CE76C008F36D2 /* CSSAnimation.idl */,
    1921719224                                713171321FBE78C500F758DE /* CSSPropertyBlendingClient.h */,
     19225                                7123C187204739BB00789392 /* CSSTransition.cpp */,
     19226                                7123C186204739BA00789392 /* CSSTransition.h */,
     19227                                7123C185204739B900789392 /* CSSTransition.idl */,
    1921819228                                71025EC41F99F096004A250C /* DocumentTimeline.cpp */,
    1921919229                                71025EC51F99F096004A250C /* DocumentTimeline.h */,

  • trunk/Source/WebCore/animation/KeyframeEffect.cpp

    r228446 r229340  
    2626#include "config.h"
    2727#include "KeyframeEffect.h"
     28
     29#include "AnimationEffectTiming.h"
    2830
    2931namespace WebCore {

  • trunk/Source/WebCore/animation/WebAnimation.h

    r229327 r229340  
    5454
    5555    virtual bool isCSSAnimation() const { return false; }
     56    virtual bool isCSSTransition() const { return false; }
    5657
    5758    const String& id() const { return m_id; }

  • trunk/Source/WebCore/bindings/js/JSWebAnimationCustom.cpp

    r229327 r229340  
    3030#include "JSAnimationTimeline.h"
    3131#include "JSCSSAnimation.h"
     32#include "JSCSSTransition.h"
    3233#include "JSDOMConstructor.h"
    3334
    … …  
    4041    if (value->isCSSAnimation())
    4142        return createWrapper<CSSAnimation>(globalObject, WTFMove(value));
     43    if (value->isCSSTransition())
     44        return createWrapper<CSSTransition>(globalObject, WTFMove(value));
    4245    return createWrapper<WebAnimation>(globalObject, WTFMove(value));
    4346}

  • trunk/Source/WebCore/bindings/js/WebCoreBuiltinNames.h

    r229327 r229340  
    5151    macro(CredentialsContainer) \
    5252    macro(CSSAnimation) \
     53    macro(CSSTransition) \
    5354    macro(CustomElementRegistry) \
    5455    macro(DataTransferItem) \
Note: See TracChangeset for help on using the changeset viewer.