Changeset 229381 in webkit

Timestamp:

Mar 7, 2018 4:16:54 PM (6 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Allow apple_additions() to define additional ports
​https://bugs.webkit.org/show_bug.cgi?id=183412
<rdar://problem/38232353>

Reviewed by Aakash Jain.

• Scripts/webkitpy/port/factory.py:

(PortFactory.get): Allow apple_additions to define port classes to be used
in run-webkit-tests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/port/factory.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-03-07  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Allow apple_additions() to define additional ports
+        https://bugs.webkit.org/show_bug.cgi?id=183412
+        <rdar://problem/38232353>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/port/factory.py:
+        (PortFactory.get): Allow apple_additions to define port classes to be used
+        in run-webkit-tests.
+
 2018-03-07  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/port/factory.py

@@ -119 +119 @@
         port_name = port_name or self._default_port(options)
 
+        classes = []
         for port_class in self.PORT_CLASSES:
             module_name, class_name = port_class.rsplit('.', 1)
             module = __import__(module_name, globals(), locals(), [], -1)
             cls = module.__dict__[class_name]
+            classes.append(cls)
+        if config.apple_additions() and hasattr(config.apple_additions(), 'ports'):
+            classes += config.apple_additions().ports()
+
+        for cls in classes:
             if port_name.startswith(cls.port_name):
                 port_name = cls.determine_full_port_name(self._host, options, port_name)