Changeset 229548 in webkit


Ignore:
Timestamp:
Mar 12, 2018 2:16:35 PM (6 years ago)
Author:
youenn@apple.com
Message:

RTCPeerConnection's close method should update signalingState
https://bugs.webkit.org/show_bug.cgi?id=174314
<rdar://problem/33267977>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt:

Source/WebCore:

Covered by rebased test.
Add closed as signalingState enum value.
Set peer connection signaling state to closed once close is called.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::doClose):

  • Modules/mediastream/RTCSignalingState.idl:
  • platform/mediastream/RTCSignalingState.h:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r229544 r229548  
     12018-03-12  Youenn Fablet  <youenn@apple.com>
     2
     3        RTCPeerConnection's close method should update signalingState
     4        https://bugs.webkit.org/show_bug.cgi?id=174314
     5        <rdar://problem/33267977>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt:
     10
    1112018-03-12  Chris Dumez  <cdumez@apple.com>
    212
  • trunk/LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt

    r222307 r229548  
    11
    22PASS createDataChannel with no argument should throw TypeError
    3 FAIL createDataChannel with closed connection should throw InvalidStateError assert_equals: signaling state expected "closed" but got "stable"
     3PASS createDataChannel with closed connection should throw InvalidStateError
    44FAIL createDataChannel attribute default values assert_equals: expected (string) "low" but got (undefined) undefined
    55FAIL createDataChannel with provided parameters should initialize attributes to provided values Type error
  • trunk/Source/WebCore/ChangeLog

    r229547 r229548  
     12018-03-12  Youenn Fablet  <youenn@apple.com>
     2
     3        RTCPeerConnection's close method should update signalingState
     4        https://bugs.webkit.org/show_bug.cgi?id=174314
     5        <rdar://problem/33267977>
     6
     7        Reviewed by Eric Carlson.
     8
     9        Covered by rebased test.
     10        Add closed as signalingState enum value.
     11        Set peer connection signaling state to closed once close is called.
     12
     13        * Modules/mediastream/RTCPeerConnection.cpp:
     14        (WebCore::RTCPeerConnection::doClose):
     15        * Modules/mediastream/RTCSignalingState.idl:
     16        * platform/mediastream/RTCSignalingState.h:
     17
    1182018-03-12  Mark Lam  <mark.lam@apple.com>
    219
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp

    r226804 r229548  
    395395    m_connectionState = RTCPeerConnectionState::Closed;
    396396    m_iceConnectionState = RTCIceConnectionState::Closed;
     397    m_signalingState = RTCSignalingState::Closed;
    397398
    398399    for (auto& transceiver : m_transceiverSet->list()) {
  • trunk/Source/WebCore/Modules/mediastream/RTCSignalingState.idl

    r214030 r229548  
    3232    "have-remote-offer",
    3333    "have-local-pranswer",
    34     "have-remote-pranswer"
     34    "have-remote-pranswer",
     35    "closed"
    3536};
  • trunk/Source/WebCore/platform/mediastream/RTCSignalingState.h

    r225696 r229548  
    3535    HaveLocalPranswer,
    3636    HaveRemotePranswer,
     37    Closed,
    3738};
    3839
Note: See TracChangeset for help on using the changeset viewer.