Changeset 230406 in webkit

Timestamp:

Apr 9, 2018 5:13:57 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r229499 - AX: AOM: More accessibility events support
​https://bugs.webkit.org/show_bug.cgi?id=183023
<rdar://problem/37764380>

Reviewed by Chris Fleizach.

Source/WebCore:

The test is crashing when we call updateBackingStore when
the AXObjectCache object is gone. Added a check to fix that.

Modified the test by using the right format of setTimeout and extended the delay.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::updateBackingStore):

LayoutTests:

• accessibility/mac/AOM-events-webarea-crash.html:

Location:

releases/WebKitGTK/webkit-2.20

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityObject.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.20/LayoutTests/ChangeLog

@@ +1 @@
+2018-03-09  Nan Wang  <n_wang@apple.com>
+
+        AX: AOM: More accessibility events support
+        https://bugs.webkit.org/show_bug.cgi?id=183023
+        <rdar://problem/37764380>
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/mac/AOM-events-webarea-crash.html:
+
 2018-03-07  Zalan Bujtas  <zalan@apple.com>
 

releases/WebKitGTK/webkit-2.20/Source/WebCore/ChangeLog

@@ +1 @@
+2018-03-09  Nan Wang  <n_wang@apple.com>
+
+        AX: AOM: More accessibility events support
+        https://bugs.webkit.org/show_bug.cgi?id=183023
+        <rdar://problem/37764380>
+
+        Reviewed by Chris Fleizach.
+
+        The test is crashing when we call updateBackingStore when 
+        the AXObjectCache object is gone. Added a check to fix that.
+
+        Modified the test by using the right format of setTimeout and extended the delay.
+
+        * accessibility/AccessibilityObject.cpp:
+        (WebCore::AccessibilityObject::updateBackingStore):
+
 2018-03-12  Danyao Wang  <danyao@chromium.org>
 

releases/WebKitGTK/webkit-2.20/Source/WebCore/accessibility/AccessibilityObject.cpp

@@ -1766 +1766 @@
 void AccessibilityObject::updateBackingStore()
 {
+    if (!axObjectCache())
+        return;
+    
     // Updating the layout may delete this object.
     RefPtr<AccessibilityObject> protectedThis(this);