Changeset 230440 in webkit


Ignore:
Timestamp:
Apr 9, 2018 9:10:52 AM (6 years ago)
Author:
Wenson Hsieh
Message:

[Extra zoom mode] Disable fast clicking by default in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=184411
<rdar://problem/38726867>

Reviewed by Andy Estes.

As it turns out, existing fast-clicking heuristics don't work so well in extra zoom mode. Even at device-width,
since the page is scaled to fit within the viewport, having single taps take precedence over double taps leads
to a confusing experience when trying to double tap to zoom further on content that contains links and other
click targets. Revert to legacy behavior here by disabling these heuristics.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r230439 r230440  
     12018-04-09  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        [Extra zoom mode] Disable fast clicking by default in extra zoom mode
     4        https://bugs.webkit.org/show_bug.cgi?id=184411
     5        <rdar://problem/38726867>
     6
     7        Reviewed by Andy Estes.
     8
     9        As it turns out, existing fast-clicking heuristics don't work so well in extra zoom mode. Even at device-width,
     10        since the page is scaled to fit within the viewport, having single taps take precedence over double taps leads
     11        to a confusing experience when trying to double tap to zoom further on content that contains links and other
     12        click targets. Revert to legacy behavior here by disabling these heuristics.
     13
     14        * UIProcess/API/Cocoa/WKWebView.mm:
     15        (-[WKWebView _initializeWithConfiguration:]):
     16
    1172018-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
    218
  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

    r230268 r230440  
    657657    _viewportMetaTagWidth = WebCore::ViewportArguments::ValueAuto;
    658658    _initialScaleFactor = 1;
    659     _fastClickingIsDisabled = [[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitFastClickingDisabled"];
     659
     660    if (NSNumber *enabledValue = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKitFastClickingDisabled"])
     661        _fastClickingIsDisabled = enabledValue.boolValue;
     662    else {
     663#if ENABLE(EXTRA_ZOOM_MODE)
     664        _fastClickingIsDisabled = YES;
     665#else
     666        _fastClickingIsDisabled = NO;
     667#endif
     668    }
    660669
    661670    [self _frameOrBoundsChanged];
Note: See TracChangeset for help on using the changeset viewer.