Changeset 230512 in webkit

Timestamp:

Apr 10, 2018 7:49:10 PM (6 years ago)

Author:

Brent Fulgham

Message:

Unreviewed follow-up to r230468.

Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.

Source/WebCore:

• page/mac/EventHandlerMac.mm:

(WebCore::lastEventIsMouseUp):
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

• platform/mac/EventLoopMac.mm:

(WebCore::EventLoop::cycle):

Source/WebKit:

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::setCursor):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/mac/EventHandlerMac.mm (modified) (2 diffs)
• WebCore/platform/mac/EventLoopMac.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/mac/PageClientImplMac.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-04-10  Brent Fulgham  <bfulgham@apple.com>
+
+        Unreviewed follow-up to r230468.
+
+        Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.
+
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::lastEventIsMouseUp):
+        (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
+        * platform/mac/EventLoopMac.mm:
+        (WebCore::EventLoop::cycle):
+
 2018-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/page/mac/EventHandlerMac.mm

@@ -202 +202 @@
 
     ASSERT([NSApp isRunning]);
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
@@ -573 +573 @@
         return;
 
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;

trunk/Source/WebCore/platform/mac/EventLoopMac.mm

@@ -40 +40 @@
         return;
     }
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 #endif
     [NSApp setWindowsNeedUpdate:YES];

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-10  Brent Fulgham  <bfulgham@apple.com>
+
+        Unreviewed follow-up to r230468.
+
+        Switch some RELEASE_ASSERTs in hot codepaths to normal DEBUG asserts.
+
+        * UIProcess/mac/PageClientImplMac.mm:
+        (WebKit::PageClientImpl::isViewWindowActive):
+        (WebKit::PageClientImpl::setCursor):
+
 2018-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/UIProcess/mac/PageClientImplMac.mm

@@ -162 +162 @@
 bool PageClientImpl::isViewWindowActive()
 {
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
     NSWindow *activeViewWindow = activeWindow();
     return activeViewWindow.isKeyWindow || [NSApp keyWindow] == activeViewWindow;
@@ -293 +293 @@
 void PageClientImpl::setCursor(const WebCore::Cursor& cursor)
 {
-    RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
+    ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
     // FIXME: Would be nice to share this code with WebKit1's WebChromeClient.